Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added a notification for each operation #212

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Added a notification for each operation #212

wants to merge 1 commit into from

Conversation

micz
Copy link
Contributor

@micz micz commented Feb 10, 2025

See #202.

@micz micz mentioned this pull request Feb 10, 2025
Open
kewisch
kewisch requested changes Feb 11, 2025
View reviewed changes
Copy link
Owner

@kewisch kewisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes I'd like to ask for, thank you for making the extra effort on this one, great work so far!

@micz
Copy link
Contributor Author

micz commented Feb 12, 2025

I replied to all the comments.
Where I didn't ask for anything, I'll resolve the conversation once it's implemented in my branch.

@micz
Copy link
Contributor Author

micz commented Feb 13, 2025

I updated the PR with all the requested modifications.

kewisch
kewisch requested changes Feb 14, 2025
View reviewed changes
Copy link
Owner

@kewisch kewisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with these last minor changes, thank you for working on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kewisch kewisch kewisch requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@micz @kewisch