broken conversion of lcio particle IDs that were not created using the PID handler

[Zehvogel]

#51 breaks conversion of lcio particle IDs that were not created using the PID handler. I don't know if we consider this a bug but for instance TrueJet output seems to fail in

k4EDM4hep2LcioConv/k4EDM4hep2LcioConv/include/k4EDM4hep2LcioConv/k4Lcio2EDM4hepConv.ipp

Lines 170 to 182 in 016c9eb

	for (const auto lcioPid : rval->getParticleIDs()) {
	auto pid = convertParticleID(lcioPid);
	pid.setParticle(lval);
	if (auto pidIt = particleIDs.find(pid.getAlgorithmType());
	pidIt != particleIDs.end()) {
	pidIt->second->push_back(pid);
	} else {
	std::cerr << "ERROR: Found a PID object with an algorithm ID that is "
	"not known to the PIDHandler (id = "
	<< pid.getAlgorithmType() << ")" << std::endl;
	}
	}
	}

and I suspect this is because it has no algorithm id as it does not use the PIDHandler but adds the PID directly like here

        ParticleIDImpl* pid = new ParticleIDImpl; 
        pid->setPDG(k[elementon[i_jet]][2]);
        pid->setType(pid_type[i_jet]);
        true_jet->addParticleID(pid);
        true_jet->ext<TJindex>()=i_jet; 

I did not check if any other processors do the same, it might be quicker to just make TrueJet use the PIDHandler... :)

[tmadlener]

I would consider this a bug in TrueJet.

I did not check if any other processors do the same, it might be quicker to just make TrueJet use the PIDHandler... :)

I think so, yes.