Use property to control whether duplicate IDs are checked #295
+29
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
reviewed
Feb 26, 2025
There was a problem hiding this comment.
Since we are doing this for debug builds only, would it make sense to make m_uniqueIDs a map of hash / seed to (event, run number, algo name) so that we have access to both entries for a collision? I guess if you are debugging a collision that would be quite useful.
m-fila
force-pushed
the
uidgen_checkduplicates
branch
from
7d2e508 to
0c24ed4
Compare
tmadlener
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
UniqueIDGenSvcpropertyThrowIfDuplicatewithCheckDuplicates. The service will cache ids and check duplicates only ifCheckDuplicatesis set totrue. It's enabled by default for the Debug builds.ENDRELEASENOTES
The property will control whether to cache the ids so the long running jobs can disable it to avoid possible memory exhaustion.
As suggested in #294 (comment) the option to control whether in case of duplicate to throw an exception or print error is removed. Now it'll throw an exception. I think it's ok for debugging.
The default value of
CheckDuplicatesdepends on a build type and is taken fromNDEBUGPart of #294