Fix missing collections with IOSvc when using convertAll=True #225
+156
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and add a test that checks this.
1 task
1 task
m-fila
reviewed
Feb 28, 2025
| "--use-gaudi-algorithm", | ||
| action="store_true", | ||
| default=False, | ||
| help="Use IOSvc instead of PodioDataSvc", |
There was a problem hiding this comment.
Suggested change
| help="Use IOSvc instead of PodioDataSvc", | |
| help="Use algorithm based on Gaudi::Algorithm instead of a functional algorithm", |
There was a problem hiding this comment.
or maybe just "Use non-functional algorithm"?
tmadlener
reviewed
Feb 28, 2025
| if args.use_gaudi_algorithm: | ||
| mcLinkConverter.convertAll = True | ||
| else: | ||
| mcLinkConverter.convertAll = False |
There was a problem hiding this comment.
Can we remove this differentiation here? I think I originally put it in effectively as an optimization. Or would this still require key4hep/k4FWCore#290
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
convertAll=TruePseudoRecoAlgorithmtoPseudoRecoFunctionaland create a newPseudoRecoAlgorithmthat implements aGaudi::AlgorithmENDRELEASENOTES
The issue here was that not every check that is being done in
Writer.cppin k4FWCore is being done since the function there only looks at the names and makes the checks later, while here it is convenient to make the checks at the same time because it is expected this way in some parts of the wrapper (the if - else to check forPodioDataSvcorIOSvcare simpler this way).Fix #219.