Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Expose gokart version #2

Open
kuritka opened this issue Sep 7, 2021 · 1 comment
Open

[Feature] Expose gokart version #2

kuritka opened this issue Sep 7, 2021 · 1 comment

Comments

@kuritka
Copy link

kuritka commented Sep 7, 2021 •
edited
Loading

It would be nice if I could explicitly specify the version of the gokart as action argument.

The reason is that locally I can use a different version of the gokart than in action. This would create an inconsistency where the action gokart would return different results than the local scan.

WDYT?
kuritka added a commit to k8gb-io/k8gb that referenced this issue Sep 7, 2021
@kuritka
Gokart action
3707262 
related to #600
I considered using a go-kart action. Unfortunately it is not yet mature enough to use it
([1](kitabisa/gokart-action#2), [2](kitabisa/gokart-action#1)).

During the processing `build.yaml` I run gokart the same way as for example golic.

Signed-off-by: kuritka <kuritka@gmail.com>
kuritka added a commit to k8gb-io/k8gb that referenced this issue Sep 7, 2021
@kuritka
Gokart action
cae3d66 
closes #600
I considered using a go-kart action. Unfortunately it is not yet mature enough to use it ([[1]](kitabisa/gokart-action#2), [[2]](kitabisa/gokart-action#1)).
During the processing `build.yaml` I run gokart the same way as for example golic.

Signed-off-by: kuritka <kuritka@gmail.com>
@kuritka kuritka mentioned this issue Sep 7, 2021
Merged
@dwisiswant0
Copy link
Contributor

If we just expose what version of GoKart using, that's fine. But I don't think it's possible to "specify the version of the gokart as action argument", because I believe if it's dynamic, then the action inputs should be too.

kuritka added a commit to k8gb-io/k8gb that referenced this issue Sep 10, 2021
@kuritka
Gokart action (#604)
c68a890 
closes #600
I considered using a go-kart action. Unfortunately it is not yet mature enough to use it ([[1]](kitabisa/gokart-action#2), [[2]](kitabisa/gokart-action#1)).
During the processing `build.yaml` I run gokart the same way as for example golic.

Signed-off-by: kuritka <kuritka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kuritka @dwisiswant0