Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements in Logos Block #29

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Tishasoumya-02
Copy link
Contributor

@Tishasoumya-02 Tishasoumya-02 commented Feb 10, 2025

For similar width and height images , this block seems to work fine, but can create problems when width/height among them vary. Please do let me know on any changes required @sneridagh

Screen.Recording.2025-02-10.at.5.18.09.PM.mov

@Tishasoumya-02 Tishasoumya-02 self-assigned this Feb 10, 2025
@sneridagh
Copy link
Member

sneridagh commented Feb 12, 2025

@Tishasoumya-02 we are in the right way. However, just to be clear. The goal is to have exactly the same UX as in the new logos footer of VLT. You can play with it in: https://plone-intranet.kitconcept.com/

image

The container width is missing. Also the resultant logos UI have to behave and look like the footer does, that's why I mentioned that it has to have the same CSS, and if there's any missing, then let's add it.

Also: our base line is VLT, so please switch to develop it in there. You can add this repo using mrs.developer.json. There are some examples in VLT itself (disabled, notice the develop: false). Add this repo as another entry, then make install again (without the develop: false). I can help with this if you can't make it happen.

Then you could add the logos block in there.

@Tishasoumya-02
Copy link
Contributor Author

@sneridagh , I have made the changes, please do review it.

Screen.Recording.2025-02-18.at.7.00.43.PM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants