Fix #133

Generate SQL Server user defined types

Author: kitloong

README.md

@@ -142,9 +142,9 @@ The generator first generates all tables and then adds foreign keys to existing
 However, SQLite only supports foreign keys upon creation of the table and not when tables are altered.
 *_add_foreign_keys_* migrations will still be generated, however will get omitted if migrate to SQLite type database.
 
-## PostgreSQL Custom Column Type
+## User Defined Custom Column Type
 
-The generator will register custom data type from `pg_type`, then generate migration as
+The generator will register custom data type from the schema, then generate migration as
 
 ```php
 public function up()
@@ -158,6 +158,11 @@ public function up()
 
 Note that the new `column` is always added at the end of the created `table` which means the ordering of the column generated in migration will differ from what we have from the schema.
 
+Supported DB:
+
+- [x] PostgreSQL
+- [x] SQL Server
+
 ## Thank You
 
 Thanks to Bernhard Breytenbach for his great work. This package is cloned from https://github.com/Xethron/migrations-generator.

src/DBAL/Models/DBALCustomColumn.php

@@ -31,7 +31,14 @@ public function __construct(string $table, DoctrineDBALColumn $column)
     {
         $this->name      = $column->getName();
         $this->tableName = $table;
-        $this->sqls      = DB::getDoctrineConnection()->getDatabasePlatform()->getAlterTableSQL(new TableDiff($this->tableName, [$column]));
+
+        // COLLATE clause cannot be used on user-defined data types.
+        // Unset collation here.
+        $platformOptions = $column->getPlatformOptions();
+        unset($platformOptions['collation']);
+        $column->setPlatformOptions($platformOptions);
+
+        $this->sqls = DB::getDoctrineConnection()->getDatabasePlatform()->getAlterTableSQL(new TableDiff($this->tableName, [$column]));
     }
 
     /**

src/DBAL/RegisterColumnType.php

@@ -12,14 +12,17 @@
 use KitLoong\MigrationsGenerator\Enum\Driver;
 use KitLoong\MigrationsGenerator\Enum\Migrations\Method\ColumnType;
 use KitLoong\MigrationsGenerator\Repositories\PgSQLRepository;
+use KitLoong\MigrationsGenerator\Repositories\SQLSrvRepository;
 
 class RegisterColumnType
 {
     private $pgSQLRepository;
+    private $sqlSrvRepository;
 
-    public function __construct(PgSQLRepository $pgSQLRepository)
+    public function __construct(PgSQLRepository $pgSQLRepository, SQLSrvRepository $sqlSrvRepository)
     {
-        $this->pgSQLRepository = $pgSQLRepository;
+        $this->pgSQLRepository  = $pgSQLRepository;
+        $this->sqlSrvRepository = $sqlSrvRepository;
     }
 
     /**
@@ -128,11 +131,16 @@ public function getName()
      */
     private function getCustomTypes(): Collection
     {
-        if (DB::getDriverName() === Driver::PGSQL()->getValue()) {
-            return $this->pgSQLRepository->getCustomDataTypes();
-        }
+        switch (DB::getDriverName()) {
+            case Driver::PGSQL():
+                return $this->pgSQLRepository->getCustomDataTypes();
+
+            case Driver::SQLSRV():
+                return $this->sqlSrvRepository->getCustomDataTypes();
 
-        return new Collection();
+            default:
+                return new Collection();
+        }
     }
 
     /**

src/Repositories/SQLSrvRepository.php

@@ -194,4 +194,23 @@ public function getEnumPresetValues(string $table, string $column): Collection
 
         return new Collection(array_reverse(explode('\' OR ' . $separator, $value)));
     }
+
+    /**
+     * Get a list of custom data types.
+     *
+     * @return \Illuminate\Support\Collection<string>
+     */
+    public function getCustomDataTypes(): Collection
+    {
+        $rows  = DB::select("SELECT * FROM sys.types WHERE is_user_defined = 1");
+        $types = new Collection();
+
+        if (count($rows) > 0) {
+            foreach ($rows as $row) {
+                $types->push($row->name);
+            }
+        }
+
+        return $types;
+    }
 }

tests/Feature/SQLSrv/CommandTest.php

@@ -34,6 +34,10 @@ public function testRun()
     {
         $migrateTemplates = function () {
             $this->migrateGeneral('sqlsrv');
+
+            DB::statement(
+                "ALTER TABLE all_columns_sqlsrv ADD accountnumber accountnumber NOT NULL"
+            );
         };
 
         $generateMigrations = function () {

tests/Feature/SQLSrv/SQLSrvTestCase.php

@@ -31,6 +31,17 @@ protected function getEnvironmentSetUp($app)
         ]);
     }
 
+    protected function setUp(): void
+    {
+        parent::setUp();
+
+        // Drop first.
+        DB::statement("DROP TYPE IF EXISTS accountnumber");
+
+        // Create for custom column type test.
+        DB::statement("CREATE TYPE accountnumber FROM [nvarchar](15) NULL");
+    }
+
     protected function dumpSchemaAs(string $destination): void
     {
         $tables = DB::getDoctrineSchemaManager()->listTableNames();