Merge pull request #60 from kitloong/feature/nullcheck

Check if type information return null #58

Author: kitloong

src/MigrationsGenerator/Generators/Columns/DatetimeColumn.php

@@ -129,13 +129,19 @@ private function getLength(string $table, Column $column): ?int
      */
     private function getPgSQLLength(string $table, Column $column): ?int
     {
-        $rawType = ($this->pgSQLRepository->getTypeByColumnName($table, $column->getName()));
-        $length  = $this->regex->getTextBetween($rawType);
+        $rawType = $this->pgSQLRepository->getTypeByColumnName($table, $column->getName());
+        if ($rawType === null) {
+            // @codeCoverageIgnoreStart
+            return null;
+            // @codeCoverageIgnoreEnd
+        }
+
+        $length = $this->regex->getTextBetween($rawType);
         if ($length !== null) {
             return (int) $length;
-        } else {
-            return null;
         }
+
+        return null;
     }
 
     /**
@@ -158,7 +164,6 @@ private function getSQLSrvLength(string $table, Column $column): ?int
                 } else {
                     return $column->getScale();
                 }
-                // no break
             case DateTimeTzType::class:
             case DateTimeTzImmutableType::class:
                 if ($colDef->getScale() === self::SQLSRV_DATETIME_TZ_EMPTY_SCALE &&
@@ -167,7 +172,6 @@ private function getSQLSrvLength(string $table, Column $column): ?int
                 } else {
                     return $column->getScale();
                 }
-                // no break
             default:
                 return $column->getScale();
         }

src/MigrationsGenerator/Repositories/PgSQLRepository.php

@@ -37,7 +37,10 @@ public function getTypeByColumnName(string $table, string $column): ?string
         if (count($columnDetail) > 0) {
             return $columnDetail[0]->datatype;
         }
+
+        // @codeCoverageIgnoreStart
         return null;
+        // @codeCoverageIgnoreEnd
     }
 
     /**
@@ -71,7 +74,10 @@ public function getCheckConstraintDefinition(string $table, string $column): ?st
         if (count($columnDetail) > 0) {
             return $columnDetail[0]->definition;
         }
+
+        // @codeCoverageIgnoreStart
         return null;
+        // @codeCoverageIgnoreEnd
     }
 
     /**