Use DB::unprepared

Author: kitloong

src/Migration/Blueprint/DBUnpreparedBlueprint.php

@@ -0,0 +1,50 @@
+<?php
+
+namespace KitLoong\MigrationsGenerator\Migration\Blueprint;
+
+use KitLoong\MigrationsGenerator\Migration\Blueprint\Support\MethodStringHelper;
+use KitLoong\MigrationsGenerator\Migration\Blueprint\Support\Stringable;
+
+/**
+ * Create migration lines with `DB::unprepared`.
+ *
+ * eg 1:
+ * ```
+ * DB::statement("CREATE PROCEDURE myProcedure() BEGIN SELECT * from table END");
+ * ```
+ *
+ * eg 2:
+ * ```
+ * DB::connection('sqlite')->statement("CREATE PROCEDURE myProcedure() BEGIN SELECT * from table END");
+ * ```
+ */
+class DBUnpreparedBlueprint implements WritableBlueprint
+{
+    use Stringable;
+    use MethodStringHelper;
+
+    /**
+     * @var string
+     */
+    private $sql;
+
+    /**
+     * DBStatementBlueprint constructor.
+     *
+     * @param  string  $sql  The SQL statement.
+     */
+    public function __construct(string $sql)
+    {
+        $this->sql = $sql;
+    }
+
+    /**
+     * @inheritDoc
+     */
+    public function toString(): string
+    {
+        $method = $this->connection('DB', 'unprepared');
+        $query  = $this->escapeDoubleQuote($this->sql);
+        return "$method(\"$query\");";
+    }
+}

src/Migration/ProcedureMigration.php

@@ -4,7 +4,7 @@
 
 use Carbon\Carbon;
 use Illuminate\Support\Collection;
-use KitLoong\MigrationsGenerator\Migration\Blueprint\DBStatementBlueprint;
+use KitLoong\MigrationsGenerator\Migration\Blueprint\DBUnpreparedBlueprint;
 use KitLoong\MigrationsGenerator\Migration\Enum\MigrationFileType;
 use KitLoong\MigrationsGenerator\Migration\Writer\MigrationWriter;
 use KitLoong\MigrationsGenerator\Migration\Writer\SquashWriter;
@@ -70,22 +70,22 @@ public function writeToTemp(Procedure $procedure): void
      * Generates `up` db statement for stored procedure.
      *
      * @param  \KitLoong\MigrationsGenerator\Schema\Models\Procedure  $procedure
-     * @return \KitLoong\MigrationsGenerator\Migration\Blueprint\DBStatementBlueprint
+     * @return \KitLoong\MigrationsGenerator\Migration\Blueprint\DBUnpreparedBlueprint
      */
-    private function up(Procedure $procedure): DBStatementBlueprint
+    private function up(Procedure $procedure): DBUnpreparedBlueprint
     {
-        return new DBStatementBlueprint($procedure->getDefinition());
+        return new DBUnpreparedBlueprint($procedure->getDefinition());
     }
 
     /**
      * Generates `down` db statement for stored procedure.
      *
      * @param  \KitLoong\MigrationsGenerator\Schema\Models\Procedure  $procedure
-     * @return \KitLoong\MigrationsGenerator\Migration\Blueprint\DBStatementBlueprint
+     * @return \KitLoong\MigrationsGenerator\Migration\Blueprint\DBUnpreparedBlueprint
      */
-    private function down(Procedure $procedure): DBStatementBlueprint
+    private function down(Procedure $procedure): DBUnpreparedBlueprint
     {
-        return new DBStatementBlueprint($procedure->getDropDefinition());
+        return new DBUnpreparedBlueprint($procedure->getDropDefinition());
     }
 
     /**

tests/Feature/MariaDB/MariaDBTestCase.php

@@ -70,7 +70,7 @@ protected function dropAllProcedures(): void
         $procedures = DB::select("SHOW PROCEDURE STATUS where DB='" . config('database.connections.mariadb.database') . "'");
 
         foreach ($procedures as $procedure) {
-            DB::statement("DROP PROCEDURE IF EXISTS " . $procedure->Name);
+            DB::unprepared("DROP PROCEDURE IF EXISTS " . $procedure->Name);
         }
     }
 }

tests/Feature/MySQL57/MySQL57TestCase.php

@@ -71,7 +71,7 @@ protected function dropAllProcedures(): void
         $procedures = DB::select("SHOW PROCEDURE STATUS where DB='" . config('database.connections.mysql57.database') . "'");
 
         foreach ($procedures as $procedure) {
-            DB::statement("DROP PROCEDURE IF EXISTS " . $procedure->Name);
+            DB::unprepared("DROP PROCEDURE IF EXISTS " . $procedure->Name);
         }
     }
 }

tests/Feature/MySQL8/MySQL8TestCase.php

@@ -70,7 +70,7 @@ protected function dropAllProcedures(): void
         $procedures = DB::select("SHOW PROCEDURE STATUS where DB='" . config('database.connections.mysql8.database') . "'");
 
         foreach ($procedures as $procedure) {
-            DB::statement("DROP PROCEDURE IF EXISTS " . $procedure->Name);
+            DB::unprepared("DROP PROCEDURE IF EXISTS " . $procedure->Name);
         }
     }
 }

tests/Feature/PgSQL/PgSQLTestCase.php

@@ -96,7 +96,7 @@ protected function dropAllProcedures(): void
         );
 
         foreach ($procedures as $procedure) {
-            DB::statement("DROP PROCEDURE IF EXISTS " . $procedure->proname);
+            DB::unprepared("DROP PROCEDURE IF EXISTS " . $procedure->proname);
         }
     }
 }

tests/Feature/SQLSrv/SQLSrvTestCase.php

@@ -97,7 +97,7 @@ protected function dropAllProcedures(): void
         $procedures = $this->getAllProcedures();
 
         foreach ($procedures as $procedure) {
-            DB::statement("DROP PROCEDURE IF EXISTS " . $procedure->name);
+            DB::unprepared("DROP PROCEDURE IF EXISTS " . $procedure->name);
         }
     }
 

tests/resources/database/migrations/general/2020_03_21_000001_expected_create_quoted_name_db_proc.php

@@ -19,28 +19,28 @@ public function up()
     {
         switch (DB::getDriverName()) {
             case Driver::MYSQL():
-                DB::statement(
+                DB::unprepared(
                     "CREATE PROCEDURE findNameWithHyphen[db]()
                     BEGIN
-                        SELECT * from ".$this->quoteIdentifier('name-with-hyphen-[db]').";
+                        SELECT * from " . $this->quoteIdentifier('name-with-hyphen-[db]') . ";
                     END"
                 );
                 break;
             case Driver::PGSQL():
-                DB::statement(
+                DB::unprepared(
                     "CREATE PROCEDURE findNameWithHyphen[db]()
                     language plpgsql
                     as $$
                     BEGIN
-                        SELECT * from ".$this->quoteIdentifier('name-with-hyphen-[db]').";
+                        SELECT * from " . $this->quoteIdentifier('name-with-hyphen-[db]') . ";
                     END;$$"
                 );
                 break;
             case Driver::SQLSRV():
-                DB::statement(
+                DB::unprepared(
                     "CREATE PROCEDURE findNameWithHyphen[db]
                     AS
-                    SELECT * from ".$this->quoteIdentifier('name-with-hyphen-[db]').";"
+                    SELECT * from " . $this->quoteIdentifier('name-with-hyphen-[db]') . ";"
                 );
                 break;
             default:
@@ -54,6 +54,6 @@ public function up()
      */
     public function down()
     {
-        DB::statement("DROP PROCEDURE IF EXISTS findNameWithHyphen[db]");
+        DB::unprepared("DROP PROCEDURE IF EXISTS findNameWithHyphen[db]");
     }
 }