Merge pull request #215 from kitloong/feature/lint

Lint

Author: kitloong

.github/FUNDING.yml

@@ -1,3 +1,2 @@
-# These are supported funding model platforms
-
-custom: ['https://www.buymeacoffee.com/kitloong']
+github: kitloong
+buy_me_a_coffee: kitloong

src/MigrateGenerateCommand.php

@@ -626,21 +626,12 @@ protected function makeSchema(): Schema
             throw new Exception('Failed to find database driver.');
         }
 
-        switch ($driver) {
-            case Driver::MYSQL->value:
-                return $this->schema = app(MySQLSchema::class);
-
-            case Driver::PGSQL->value:
-                return $this->schema = app(PgSQLSchema::class);
-
-            case Driver::SQLITE->value:
-                return $this->schema = app(SQLiteSchema::class);
-
-            case Driver::SQLSRV->value:
-                return $this->schema = app(SQLSrvSchema::class);
-
-            default:
-                throw new Exception('The database driver in use is not supported.');
-        }
+        return match ($driver) {
+            Driver::MYSQL->value => $this->schema  = app(MySQLSchema::class),
+            Driver::PGSQL->value => $this->schema  = app(PgSQLSchema::class),
+            Driver::SQLITE->value => $this->schema = app(SQLiteSchema::class),
+            Driver::SQLSRV->value => $this->schema = app(SQLSrvSchema::class),
+            default => throw new Exception('The database driver in use is not supported.'),
+        };
     }
 }

src/Migration/Blueprint/DBStatementBlueprint.php

@@ -29,7 +29,7 @@ class DBStatementBlueprint implements WritableBlueprint
      *
      * @param  string  $sql  The SQL statement.
      */
-    public function __construct(private string $sql)
+    public function __construct(private readonly string $sql)
     {
     }
 

src/Migration/Blueprint/DBUnpreparedBlueprint.php

@@ -29,7 +29,7 @@ class DBUnpreparedBlueprint implements WritableBlueprint
      *
      * @param  string  $sql  The SQL statement.
      */
-    public function __construct(private string $sql)
+    public function __construct(private readonly string $sql)
     {
     }
 

src/Migration/Blueprint/Method.php

@@ -22,7 +22,7 @@ class Method
      * @param  \KitLoong\MigrationsGenerator\Enum\Migrations\Method\MethodName  $name  Method name.
      * @param  mixed  ...$values  Method arguments.
      */
-    public function __construct(private MethodName $name, mixed ...$values)
+    public function __construct(private readonly MethodName $name, mixed ...$values)
     {
         $this->values = $values;
         $this->chains = [];

src/Migration/Blueprint/Property.php

@@ -9,7 +9,7 @@ class Property
     /**
      * Property constructor.
      */
-    public function __construct(private PropertyName $name, private mixed $value)
+    public function __construct(private readonly PropertyName $name, private readonly mixed $value)
     {
     }
 

src/Migration/Blueprint/SchemaBlueprint.php

@@ -50,7 +50,7 @@ class SchemaBlueprint implements WritableBlueprint
      * @param  string  $table  Table name.
      * @param  \KitLoong\MigrationsGenerator\Enum\Migrations\Method\SchemaBuilder  $schemaBuilder  SchemaBuilder name.
      */
-    public function __construct(string $table, private SchemaBuilder $schemaBuilder)
+    public function __construct(string $table, private readonly SchemaBuilder $schemaBuilder)
     {
         $this->table = $this->stripTablePrefix($table);
     }

src/Migration/Blueprint/TableBlueprint.php

@@ -115,18 +115,11 @@ public function toString(): string
         $lines = [];
 
         foreach ($this->lines as $line) {
-            switch (true) {
-                case $line instanceof Property:
-                    $lines[] = $this->propertyToString($line);
-                    break;
-
-                case $line instanceof Method:
-                    $lines[] = $this->methodToString($line);
-                    break;
-
-                default:
-                    $lines[] = $this->convertFromAnyTypeToString($line);
-            }
+            $lines[] = match (true) {
+                $line instanceof Property => $this->propertyToString($line),
+                $line instanceof Method => $this->methodToString($line),
+                default => $this->convertFromAnyTypeToString($line),
+            };
         }
 
         return $this->flattenLines($lines, $this->numberOfPrefixTab);

src/Migration/ForeignKeyMigration.php

@@ -19,11 +19,11 @@ class ForeignKeyMigration
     use TableName;
 
     public function __construct(
-        private ForeignKeyGenerator $foreignKeyGenerator,
-        private MigrationNameHelper $migrationNameHelper,
-        private MigrationWriter $migrationWriter,
-        private Setting $setting,
-        private SquashWriter $squashWriter,
+        private readonly ForeignKeyGenerator $foreignKeyGenerator,
+        private readonly MigrationNameHelper $migrationNameHelper,
+        private readonly MigrationWriter $migrationWriter,
+        private readonly Setting $setting,
+        private readonly SquashWriter $squashWriter,
     ) {
     }
 

src/Migration/Generator/ColumnGenerator.php

@@ -19,14 +19,14 @@
 class ColumnGenerator
 {
     public function __construct(
-        private CharsetModifier $charsetModifier,
-        private CollationModifier $collationModifier,
-        private CommentModifier $commentModifier,
-        private DefaultModifier $defaultModifier,
-        private IndexModifier $indexModifier,
-        private NullableModifier $nullableModifier,
-        private StoredAsModifier $storedAsModifier,
-        private VirtualAsModifier $virtualAsModifier,
+        private readonly CharsetModifier $charsetModifier,
+        private readonly CollationModifier $collationModifier,
+        private readonly CommentModifier $commentModifier,
+        private readonly DefaultModifier $defaultModifier,
+        private readonly IndexModifier $indexModifier,
+        private readonly NullableModifier $nullableModifier,
+        private readonly StoredAsModifier $storedAsModifier,
+        private readonly VirtualAsModifier $virtualAsModifier,
     ) {
     }
 

src/Migration/Generator/IndexGenerator.php

@@ -11,7 +11,7 @@
 
 class IndexGenerator
 {
-    public function __construct(private IndexNameHelper $indexNameHelper)
+    public function __construct(private readonly IndexNameHelper $indexNameHelper)
     {
     }
 

src/Migration/Generator/Modifiers/CharsetModifier.php

@@ -11,7 +11,7 @@
 
 class CharsetModifier implements Modifier
 {
-    public function __construct(private Setting $setting)
+    public function __construct(private readonly Setting $setting)
     {
     }
 

src/Migration/Generator/Modifiers/CollationModifier.php

@@ -10,7 +10,7 @@
 
 class CollationModifier implements Modifier
 {
-    public function __construct(private Setting $setting)
+    public function __construct(private readonly Setting $setting)
     {
     }
 

src/Migration/Generator/Modifiers/IndexModifier.php

@@ -10,7 +10,7 @@
 
 class IndexModifier implements Modifier
 {
-    public function __construct(private IndexNameHelper $indexNameHelper)
+    public function __construct(private readonly IndexNameHelper $indexNameHelper)
     {
     }
 

src/Migration/ProcedureMigration.php

@@ -14,10 +14,10 @@
 class ProcedureMigration
 {
     public function __construct(
-        private MigrationNameHelper $migrationNameHelper,
-        private MigrationWriter $migrationWriter,
-        private Setting $setting,
-        private SquashWriter $squashWriter,
+        private readonly MigrationNameHelper $migrationNameHelper,
+        private readonly MigrationWriter $migrationWriter,
+        private readonly Setting $setting,
+        private readonly SquashWriter $squashWriter,
     ) {
     }
 

src/Migration/Squash.php

@@ -9,8 +9,11 @@
 
 class Squash
 {
-    public function __construct(private SquashWriter $squashWriter, private MigrationNameHelper $migrationNameHelper, private Setting $setting)
-    {
+    public function __construct(
+        private readonly SquashWriter $squashWriter,
+        private readonly MigrationNameHelper $migrationNameHelper,
+        private readonly Setting $setting,
+    ) {
     }
 
     /**

src/Migration/TableMigration.php

@@ -28,12 +28,12 @@ class TableMigration
     use TableName;
 
     public function __construct(
-        private ColumnGenerator $columnGenerator,
-        private MigrationNameHelper $migrationNameHelper,
-        private IndexGenerator $indexGenerator,
-        private MigrationWriter $migrationWriter,
-        private Setting $setting,
-        private SquashWriter $squashWriter,
+        private readonly ColumnGenerator $columnGenerator,
+        private readonly MigrationNameHelper $migrationNameHelper,
+        private readonly IndexGenerator $indexGenerator,
+        private readonly MigrationWriter $migrationWriter,
+        private readonly Setting $setting,
+        private readonly SquashWriter $squashWriter,
     ) {
     }
 

src/Migration/ViewMigration.php

@@ -17,10 +17,10 @@ class ViewMigration
     use TableName;
 
     public function __construct(
-        private MigrationNameHelper $migrationNameHelper,
-        private MigrationWriter $migrationWriter,
-        private Setting $setting,
-        private SquashWriter $squashWriter,
+        private readonly MigrationNameHelper $migrationNameHelper,
+        private readonly MigrationWriter $migrationWriter,
+        private readonly Setting $setting,
+        private readonly SquashWriter $squashWriter,
     ) {
     }
 

src/Migration/Writer/MigrationWriter.php

@@ -12,7 +12,7 @@
 
 class MigrationWriter
 {
-    public function __construct(private MigrationStub $migrationStub)
+    public function __construct(private readonly MigrationStub $migrationStub)
     {
     }
 

src/Migration/Writer/SquashWriter.php

@@ -11,7 +11,7 @@
 
 class SquashWriter
 {
-    public function __construct(private MigrationNameHelper $migrationNameHelper, private MigrationStub $migrationStub)
+    public function __construct(private readonly MigrationNameHelper $migrationNameHelper, private readonly MigrationStub $migrationStub)
     {
     }
 

src/Repositories/Entities/MariaDB/CheckConstraint.php

@@ -36,7 +36,6 @@ public function __construct(stdClass $column)
         $this->constraintSchema  = $lowerKey['constraint_schema'];
         $this->tableName         = $lowerKey['table_name'];
         $this->constraintName    = $lowerKey['constraint_name'];
-        $this->level             = null;
 
         if (isset($lowerKey['level'])) {
             $this->level = $lowerKey['level'];

src/Repositories/Entities/MySQL/ShowColumn.php

@@ -23,7 +23,7 @@ class ShowColumn
 
     private string $key;
 
-    private ?string $default = null;
+    private ?string $default;
 
     private string $extra;
 

src/Repositories/Entities/PgSQL/IndexDefinition.php

@@ -4,8 +4,11 @@
 
 class IndexDefinition
 {
-    public function __construct(private string $tableName, private string $indexName, private string $indexDef)
-    {
+    public function __construct(
+        private readonly string $tableName,
+        private readonly string $indexName,
+        private readonly string $indexDef,
+    ) {
     }
 
     public function getTableName(): string

src/Repositories/Entities/ProcedureDefinition.php

@@ -4,7 +4,7 @@
 
 class ProcedureDefinition
 {
-    public function __construct(private string $name, private string $definition)
+    public function __construct(private readonly string $name, private readonly string $definition)
     {
     }
 

src/Repositories/Entities/SQLSrv/ColumnDefinition.php

@@ -15,17 +15,17 @@ class ColumnDefinition
 
     private bool $notnull;
 
-    private ?string $default = null;
+    private ?string $default;
 
     private int $scale;
 
     private int $precision;
 
     private bool $autoincrement;
 
-    private ?string $collation = null;
+    private ?string $collation;
 
-    private ?string $comment = null;
+    private ?string $comment;
 
     public function __construct(stdClass $column)
     {

src/Repositories/SQLSrvRepository.php

@@ -143,7 +143,7 @@ private function getTableWhereClause(string $table, string $schemaColumn, string
     {
         $schema = 'SCHEMA_NAME()';
 
-        if (strpos($table, '.') !== false) {
+        if (str_contains($table, '.')) {
             [$schema, $table] = explode('.', $table);
             $schema           = $this->quoteStringLiteral($schema);
         }

src/Support/IndexNameHelper.php

@@ -8,7 +8,7 @@
 
 class IndexNameHelper
 {
-    public function __construct(private Setting $setting)
+    public function __construct(private readonly Setting $setting)
     {
     }
 

src/Support/MigrationNameHelper.php

@@ -9,7 +9,7 @@ class MigrationNameHelper
 {
     use TableName;
 
-    public function __construct(private Setting $setting)
+    public function __construct(private readonly Setting $setting)
     {
     }