Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Reduce and explicitly define our public API #115

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

[WIP] Reduce and explicitly define our public API #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
130b258
Remove top-level imports in tests
timokau Apr 17, 2020
427d05e
Use a strict two-level structure in our public API
timokau May 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions csrank/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,3 @@
__version__ = "1.1.0"

# We should re-evaluate if we really want to re-export everything here and then
# use __all__ properly.

from .choicefunction import * # noqa
from .core import * # noqa
from .dataset_reader import * # noqa
from .discretechoice import * # noqa
from .objectranking import * # noqa
from .tunable import Tunable # noqa
from .tuning import ParameterOptimizer # noqa
__all__ = ["choicefunction", "discretechoice", "objectranking"]
4 changes: 2 additions & 2 deletions csrank/tests/test_fate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
from keras.regularizers import l2
import numpy as np

from csrank import FATENetworkCore
from csrank import FATEObjectRanker
from csrank.core import FATENetworkCore
from csrank.objectranking import FATEObjectRanker
from csrank.tests.test_ranking import optimizer


Expand Down
2 changes: 1 addition & 1 deletion csrank/tests/test_ranking.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
import pytest
import tensorflow as tf

from csrank import PairedCombinatorialLogit
from csrank.constants import CMPNET
from csrank.constants import ERR
from csrank.constants import FATE_RANKER
Expand All @@ -15,6 +14,7 @@
from csrank.constants import LISTNET
from csrank.constants import RANKNET
from csrank.constants import RANKSVM
from csrank.discretechoice import PairedCombinatorialLogit
from csrank.metrics_np import zero_one_accuracy_np
from csrank.metrics_np import zero_one_rank_loss_for_scores_ties_np
from csrank.objectranking import *
Expand Down
2 changes: 1 addition & 1 deletion csrank/tests/test_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import pytest
import tensorflow as tf

from csrank import SyntheticIterator
from csrank.dataset_reader import SyntheticIterator
from csrank.tensorflow_util import tensorify
from csrank.tuning import check_learner_class

Expand Down