-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LambdaMART implementation with latest master rebase #82
base: master
Are you sure you want to change the base?
LambdaMART implementation with latest master rebase #82
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the rebase.
Overall, the code improved a lot over the previous submission.
To finalize the submission, remember to:
- Currently, I am not able to use
predict
without it throwing an error. This should be fixed. - Fix the issues remarked in the code.
- Execute the black code formatter on your files and on the functions you added. Try to avoid reformatting existing files.
- Add LambdaMART to https://github.com/kiudee/cs-ranking/blob/master/csrank/objectranking/__init__.py for direct import (
from csrank import LambdaMART
).
…m/srinikrish22/cs-ranking into lambdamart-implementation-rebased
…unctions to the lambdamart file itself
Pull Request Test Coverage Report for Build 700
💛 - Coveralls |
Fixes have been made based on the suggested changes. I have also run the black code formatter. |
All the changes requested have been completed:
|
I have implemented the LambdaMART algorithm for object ranking. This branch has the latest rebase from the current master branch of cs-ranking.
Description
I have created a class with the required core functionality of lambdamart and added ndcg metric implementation to the utils. I have added the ranker into the test_ranking and also added the ranker definition in the constants.
Motivation and Context
This change aims at adding an implementation of a new ranker for object ranking to the repository.
How Has This Been Tested?
I have added the possibility to test this ranker under the existing testing infrastructure of the cs-ranking repository.
Does this close/impact existing issues?
Types of changes
Checklist: