-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heading docs adjustments #4622
Merged
Merged
Heading docs adjustments #4622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Storybook staging is available at https://kiwicom-orbit-domi-heading.surge.sh Playroom staging is available at https://kiwicom-orbit-domi-heading.surge.sh/playroom |
Size Change: +4 B (0%) Total Size: 461 kB
ℹ️ View Unchanged
|
Deploying orbit with
|
Latest commit: |
3e8e95a
|
Status: | ✅ Deploy successful! |
Preview URL: | https://a5fe3541.orbit.pages.dev |
Branch Preview URL: | https://domi-heading.orbit.pages.dev |
DSil
reviewed
Feb 14, 2025
docs/src/documentation/03-components/09-text/heading/03-accessibility.mdx
Outdated
Show resolved
Hide resolved
docs/src/documentation/03-components/09-text/heading/03-accessibility.mdx
Outdated
Show resolved
Hide resolved
docs/src/documentation/03-components/09-text/heading/03-accessibility.mdx
Outdated
Show resolved
Hide resolved
docs/src/documentation/03-components/09-text/heading/03-accessibility.mdx
Outdated
Show resolved
Hide resolved
docs/src/documentation/03-components/09-text/heading/03-accessibility.mdx
Outdated
Show resolved
Hide resolved
docs/src/documentation/03-components/09-text/heading/03-accessibility.mdx
Outdated
Show resolved
Hide resolved
43a3466
to
d91f447
Compare
DSil
approved these changes
Feb 17, 2025
d91f447
to
3e8e95a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://kiwicom.atlassian.net/browse/FEPLT-2287
✨
Description by Callstackai
This PR adjusts the documentation for the Heading component, improving clarity on props and their usage, particularly regarding accessibility.
Diagrams of code changes
Files Changed
This PR includes files in programming languages that we currently do not support. We have not reviewed files with the extensions
.mdx
,.md
. See list of supported languages.