-
Notifications
You must be signed in to change notification settings - Fork 331
Add gzip HTTP handler/client wrapper #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fork and clean up+extend the dead `nytimes/gziphandler` project. Includes nytimes/gziphandler#106 as well as support for stateless encoding. Removes testify from deps.
Fixes nytimes/gziphandler#83 Adds `KeepAcceptRanges()` if for whatever reason you would want to keep them.
taylorsilva
added a commit
to concourse/concourse
that referenced
this pull request
Feb 18, 2025
See klauspost/compress#383. Removes the dead nytimes/gziphandler project. klauspost/compress picked up where they left off and updated the project which is why it makes sense for us to Signed-off-by: Mathias Bogaert <mathias.bogaert@gmail.com> Co-Authored-by: Taylor Silva <dev@taydev.net>
taylorsilva
added a commit
to concourse/concourse
that referenced
this pull request
Feb 18, 2025
See klauspost/compress#383. Removes the dead nytimes/gziphandler project. klauspost/compress picked up where they left off and updated the project which is why it makes sense for us to switch to this library. Signed-off-by: Mathias Bogaert <mathias.bogaert@gmail.com> Co-Authored-by: Taylor Silva <dev@taydev.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fork and clean up+extend the dead
nytimes/gziphandler
project.http.Transport
wrapper.Default settings comparison:
Client Transport:
Speed compared to standard library for an approximate 127KB payload:
This includes both serving the http request, parsing requests and decompressing.