fix bug caused by empty strings

knox-networks · Feb 13, 2023 · f1e5bd2 · f1e5bd2
1 parent 821077e
commit f1e5bd2
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/src/lib.rs b/src/lib.rs
@@ -140,10 +140,14 @@ impl<'a> From<&'a str> for MownStr<'a> {
 }
 
 impl<'a> From<Box<str>> for MownStr<'a> {
-    fn from(other: Box<str>) -> MownStr<'a> {
+    fn from(mut other: Box<str>) -> MownStr<'a> {
         let len = other.len();
         assert!(len <= LEN_MASK);
-        let addr = NonNull::from(&other.as_bytes()[0]);
+        let addr = other.as_mut_ptr();
+        let addr = unsafe {
+            // SAFETY: ptr can not be null,
+            NonNull::new_unchecked(addr)
+        };
 
         std::mem::forget(other);
 
@@ -502,6 +506,12 @@ mod test {
         assert!(increase < 3.5);
     }
 
+    #[test]
+    fn empty_string() {
+        let empty = "".to_string();
+        let _ = MownStr::from(empty);
+    }
+
     const CAP: usize = 100_000_000;
 
     fn get_vmsize() -> usize {