-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added TimeoutManager
item retention
#6
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8c2beaa
to
6d34b6b
Compare
jsgoyette
reviewed
Sep 3, 2024
Comment on lines
+254
to
255
sm.process(ctx.init(id), input); | ||
continue; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
sm.process(ctx.init(id), input); | |
continue; | |
sm.process(ctx.init(id), input); |
jsgoyette
reviewed
Sep 3, 2024
jsgoyette
reviewed
Sep 3, 2024
jsgoyette
approved these changes
Sep 3, 2024
jkleinknox
approved these changes
Sep 4, 2024
Co-authored-by: Jeremiah Goyette <jgoyette@knox-networks.com>
Co-authored-by: Jeremiah Goyette <jgoyette@knox-networks.com>
[✅] @mkatychev: Added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TimeoutManager
can now hold aCopy
item (to be returned to sender) for a set amount of time:rex-sm/src/timeout.rs
Lines 172 to 176 in efb8b50
This opens the way for retry logic implementations that can re-run on a cadence without blocking
StateMachine
processors.StateMachine::process
is not a sync methodStateId
is now part of theSmContext
:rex-sm/src/manager.rs
Lines 129 to 134 in 0bbc754
timeout::Timeout
trait forKind
s that handle timeout items:rex-sm/src/timeout.rs
Lines 159 to 166 in efb8b50
timeout::TimeoutMessage
forRexMessage
s that handle timeoue items:rex-sm/src/timeout.rs
Lines 150 to 157 in efb8b50