Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes multiple devices grouped weird #49

Merged
merged 5 commits into from
Mar 24, 2024

Conversation

P-Storm
Copy link
Contributor

@P-Storm P-Storm commented Mar 18, 2024

Fixes #48 .

  • Ensure grouping of devices:
  • Added suggested_area to devices

Screenshots
Integration:
image
Devices:
image
Dashboard with area:
image
Dashboard without area:
image

Copy link
Owner

@koenhendriks koenhendriks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another great PR, thanks @P-Storm. Could you take a look at some of my feedback?

@P-Storm
Copy link
Contributor Author

P-Storm commented Mar 19, 2024

Yes, those comments are valid, these were still blocking. The Coordinator we need, but got some cyclic references problem, so I will look into this.

@P-Storm P-Storm requested a review from koenhendriks March 19, 2024 13:32
koenhendriks
koenhendriks previously approved these changes Mar 24, 2024
Copy link
Owner

@koenhendriks koenhendriks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update 👍

@koenhendriks
Copy link
Owner

@P-Storm Could you check the conflicts ? I'm unsure how we currently should load the topics with either topics=[Topic.from_dict(topic) for topic in data.get('topics', [])] or not.

@P-Storm
Copy link
Contributor Author

P-Storm commented Mar 24, 2024

@P-Storm Could you check the conflicts ? I'm unsure how we currently should load the topics with either topics=[Topic.from_dict(topic) for topic in data.get('topics', [])] or not.

@koenhendriks , I had to change the ordering of the Topic class, and the merge conflict was from that. I fixed it :)

@koenhendriks koenhendriks merged commit 826102c into koenhendriks:main Mar 24, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weird grouping behaviour
2 participants