New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardcoded IP address issue is commented as part of resolution and hence never gets resolved . #673

Open

sshveta opened this issue Feb 19, 2025 · 2 comments

Collaborator

sshveta commented Feb 19, 2025 •

edited

Loading

Application : https://github.com/konveyor/tackle-testapp-public

Original persistence.properties file
https://github.com/konveyor/tackle-testapp-public/blob/main/src/main/resources/persistence.properties

After resolving Hardcoded IP address issue , the line was commented and on re-analysis it keeps on discovering the commented line incident.

Commented line as shown in screenshot after applying resolution

Contributor

fabianvf commented Feb 19, 2025

This is probably an issue with the rule, it should exclude commented lines (or maybe we should in the analyzer?)

Collaborator Author

sshveta commented Feb 20, 2025

analysis_20250219T222359.json
solution_20250219T223108.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment