Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add querying to incident store #23

Merged
merged 14 commits into from
Feb 16, 2024

Conversation

savitharaghunathan
Copy link
Member

@savitharaghunathan savitharaghunathan commented Feb 7, 2024

Assumptions:

  1. Sample Analysis reports have two reports - initial & solved
  2. App.yaml is provided for all apps with details of git start and end commit
  3. Incident store is loaded once with all the apps at first, it compares initial and solved reports and creates solved issues

How to run

  1. To load incident store and create necessary files
    ./run_cli.py load samples/analysis_reports

PrereQ:
In order to run the following queries, make sure incident store is loaded and available

  1. To query solved incidents and get a patch for a given ruleset and violation
    ./run_cli.py patch quarkus/springboot javaee-pom-to-quarkus-00010

  2. To find common violations,
    ./run_cli.py common quarkus/springboot javaee-pom-to-quarkus-00010

It should generate two patches one from eap-coolstore and another from helloworld-mdb

@savitharaghunathan savitharaghunathan marked this pull request as draft February 7, 2024 01:24
@savitharaghunathan savitharaghunathan marked this pull request as ready for review February 8, 2024 22:06
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
@savitharaghunathan savitharaghunathan changed the title WIP: add querying to incident store add querying to incident store Feb 9, 2024
savitharaghunathan and others added 4 commits February 13, 2024 15:25
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
Co-authored-by: JonahSussman <sussmanjonah@gmail.com>
Co-authored-by: Jason Montleon <jmontleo@redhat.com>
Co-authored-by: Fabian von Feilitzsch <fabian@fabianism.us>
@savitharaghunathan savitharaghunathan force-pushed the solved_incidents branch 4 times, most recently from 8e7290e to 231d0fd Compare February 14, 2024 19:52
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>

Co-authored-by: JonahSussman <sussmanjonah@gmail.com>
Co-authored-by: Jason Montleon <jmontleo@redhat.com>
Co-authored-by: Fabian von Feilitzsch <fabian@fabianism.us>
Copy link
Member

@jwmatthews jwmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see we have an increasing number of good things landing in this PR. I'd prefer for us to move quick and break things opposed to going slower and cautious. My vote is to merge this once @savitharaghunathan feels good, then we can all build on top of what is in this PR.

@savitharaghunathan savitharaghunathan merged commit 5d4f4a2 into konveyor:main Feb 16, 2024
1 of 3 checks passed
@savitharaghunathan savitharaghunathan self-assigned this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants