generated from konveyor-ecosystem/template-repo
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add querying to incident store #23
Merged
savitharaghunathan
merged 14 commits into
konveyor:main
from
savitharaghunathan:solved_incidents
Feb 16, 2024
Merged
add querying to incident store #23
savitharaghunathan
merged 14 commits into
konveyor:main
from
savitharaghunathan:solved_incidents
Feb 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com> Co-authored-by: JonahSussman <sussmanjonah@gmail.com> Co-authored-by: Jason Montleon <jmontleo@redhat.com> Co-authored-by: Fabian von Feilitzsch <fabian@fabianism.us>
8e7290e
to
231d0fd
Compare
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com> Co-authored-by: JonahSussman <sussmanjonah@gmail.com> Co-authored-by: Jason Montleon <jmontleo@redhat.com> Co-authored-by: Fabian von Feilitzsch <fabian@fabianism.us>
231d0fd
to
93f74e3
Compare
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
jwmatthews
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see we have an increasing number of good things landing in this PR. I'd prefer for us to move quick and break things opposed to going slower and cautious. My vote is to merge this once @savitharaghunathan feels good, then we can all build on top of what is in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assumptions:
How to run
./run_cli.py load samples/analysis_reports
PrereQ:
In order to run the following queries, make sure incident store is loaded and available
To query solved incidents and get a patch for a given ruleset and violation
./run_cli.py patch quarkus/springboot javaee-pom-to-quarkus-00010
To find common violations,
./run_cli.py common quarkus/springboot javaee-pom-to-quarkus-00010
It should generate two patches one from eap-coolstore and another from helloworld-mdb