🐛 Removed monkey patch, OpenShift AI now works with max_completion_tokens
#685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawn-hurley
force-pushed
the
bugfix/remove-monkey-patch
branch
from
3e6383c to
523da5a
Compare
|
removed all the code to not do the validate_environment. Not all models use pydantic model validation. |
pranavgaikwad
approved these changes
Feb 25, 2025
shawn-hurley
force-pushed
the
bugfix/remove-monkey-patch
branch
from
523da5a to
0d5af37
Compare
Signed-off-by: Shawn Hurley <shawn@hurley.page>
shawn-hurley
force-pushed
the
bugfix/remove-monkey-patch
branch
from
0d5af37 to
101d32c
Compare
JonahSussman
changed the title
max_completion_tokens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #627