Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 CollapsableErrors assume validation field values are empty #692

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🐛 CollapsableErrors assume validation field values are empty #692

wants to merge 1 commit into from
+13 −1

Conversation

shawn-hurley
Copy link
Contributor

  • When doing comparison for collapsable errors, we assume that only the fields that matter are different, and everything else is reset.
  • We were not reseting the column for collapsable errors, causing them to look different for both fuzzy match and equality.
  • When it was unable to be solved, due to an error, we infinitly added parent task as a child task.

fixes #677

@shawn-hurley
CollapsableErrors assume validation field values are empty
094cff5 
* When doing comparison for collapsable errors, we assume that only the
  fields that matter are different, and everything else is reset.
* We were not reseting the column for collapsable errors, causing them
  to look different for both fuzzy match and equality.
* When it was unable to be solved, due to an error, we infinitly added
  parent task as a child task.

Signed-off-by: Shawn Hurley <shawn@hurley.page>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The kai-rpc-server log file has grown by more than 2GB in 10 minutes while resolving a single issue
1 participant
@shawn-hurley