Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows-Only] Container less: Remove condition for windows cleanup additional folders logic #433

Conversation

kthatipally
Copy link
Contributor

Summary of changes:

Signed-off-by: kthatipally <99229993+kthatipally@users.noreply.github.com>
@kthatipally
Copy link
Contributor Author

@eemcmullan , Could you please review this PR and let me know if you have any feedback? Thanks!

Copy link
Collaborator

@eemcmullan eemcmullan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the runtime import needs to be removed from that file. Otherwise LGTM. Thank you!

@eemcmullan eemcmullan added the cherry-pick/release-0.6 This PR should be cherry-picked to release-0.6 branch label Feb 19, 2025
Signed-off-by: kthatipally <99229993+kthatipally@users.noreply.github.com>
@eemcmullan eemcmullan merged commit 0fc4c6b into konveyor:main Feb 19, 2025
3 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 19, 2025
…dditional folders logic (#433)

* Remove condition for windows cleanup additional folders logic

Signed-off-by: kthatipally <99229993+kthatipally@users.noreply.github.com>

* Remove unused runtime package

Signed-off-by: kthatipally <99229993+kthatipally@users.noreply.github.com>

---------

Signed-off-by: kthatipally <99229993+kthatipally@users.noreply.github.com>
Signed-off-by: Cherry Picker <noreply@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/release-0.6 This PR should be cherry-picked to release-0.6 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants