generated from konveyor-ecosystem/template-repo
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Container-less Kantra: Update dep label selector to explicitly not scan open-source libraries when analyze-known-libraries is not set #407
Merged
pranavgaikwad
merged 2 commits into
konveyor:main
from
kthatipally:kthatipally/update-dep-label
Dec 17, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eemcmullan
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix!
… when analyze-known-libraries is not set Signed-off-by: kthatipally <99229993+kthatipally@users.noreply.github.com>
b03e080
to
f12178b
Compare
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
f12178b
to
0571564
Compare
@kthatipally I had to add this commit to fix an issue introduced due to a recent update to gh runners. hope you don't mind. |
eemcmullan
pushed a commit
to eemcmullan/kantra
that referenced
this pull request
Dec 17, 2024
…an open-source libraries when analyze-known-libraries is not set (konveyor#407) * Update dep label selector to explictly not scan open-source libraries when analyze-known-libraries is not set Signed-off-by: kthatipally <99229993+kthatipally@users.noreply.github.com> * 🐛 fix podman installation Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> --------- Signed-off-by: kthatipally <99229993+kthatipally@users.noreply.github.com> Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> Co-authored-by: Pranav Gaikwad <pgaikwad@redhat.com>
eemcmullan
pushed a commit
to eemcmullan/kantra
that referenced
this pull request
Dec 17, 2024
…an open-source libraries when analyze-known-libraries is not set (konveyor#407) * Update dep label selector to explictly not scan open-source libraries when analyze-known-libraries is not set Signed-off-by: kthatipally <99229993+kthatipally@users.noreply.github.com> * 🐛 fix podman installation Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> --------- Signed-off-by: kthatipally <99229993+kthatipally@users.noreply.github.com> Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> Co-authored-by: Pranav Gaikwad <pgaikwad@redhat.com> Signed-off-by: Emily McMullan <emcmulla@redhat.com>
pranavgaikwad
added a commit
that referenced
this pull request
Dec 17, 2024
…y not sc… (#409) Container-less Kantra: Update dep label selector to explicitly not scan open-source libraries when analyze-known-libraries is not set (#407) * Update dep label selector to explictly not scan open-source libraries when analyze-known-libraries is not set * 🐛 fix podman installation --------- Signed-off-by: kthatipally <99229993+kthatipally@users.noreply.github.com> Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> Signed-off-by: Emily McMullan <emcmulla@redhat.com> Co-authored-by: Keerthi Thatipally <99229993+kthatipally@users.noreply.github.com> Co-authored-by: Pranav Gaikwad <pgaikwad@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix the mentions/ incidents from .m2 folder even though the --analyze-known-libraries flag is not set for java binary analysis.