-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Single Select Combobox #2
Comments
I'm trying to figure out how this can be implemented. For now, I found two ways to achieve the goal: Incrementally adopted implementationA first minor release that adds a I think that we can implement the minor release splitting the
Pro: no breaking changes at first. Major release onlyLike the "incrementally adopted implementation" but without the "minor release step", so just a new major version that ships two components instead of one. Pro: Simpler to implement. What do you think? |
I'll go for a breaking change, as long as we can provide comprehensive documentation, the other versions of the app provide the compatibility required, because from here on moving forward, this will create the opportunity add features that are relevant to both workflows |
Hi everyone, I started working on the It's still a big WIP full of copied code and other ugly things, I'll try to fix everything in the next few days. The branch is here: feat-single-select-combobox |
Thanks @it-nalon for taking this up, much appreciated. I reckon when you do get the chance to send a PR we can take a look at it. |
Hi everyone, we have done some changes to the I have also some suggestions: upgrade tsdx to the latest version, add Storybook, change the naming from: "AutoComplete" to "Autocomplete", etc. Maybe we can make a new branch with a npm package (with also a "next" Github label for iusses) where we can work togheter on this new version of the library. |
Yeah, you beat me to storybook 😆 . let's create the |
@it-nalon any updates on this. let me know if you need some assistance |
Hi @koolamusic, sorry for the delay. I correctly added Storybook and it works like a charm, just missing the documentation, the tests and the "Example" project in which I found some difficulties to make it run correctly. We're already using this version in production since 1 month and it works perfectly for now. Sorry again for the delay! |
sure, sounds good to me. Storybook is important right now as I wrote this for a project I was working on, however to start adding more features in isolation, I think it would be extremely beneficial to adopt storybook from now on-wards. Meanwhile thanks for all the hard work on this one. Much appreciated |
Great! |
sure. feel free |
This will be a wrapper around https://downshift.netlify.app/use-combobox
Will document thoughts while at it
The text was updated successfully, but these errors were encountered: