GDALDataset::BuildOverviews(): fix memleak in error code path (master only)

rouault · rouault · commit badc1cd71452 · 2025-01-05T20:41:21.000+01:00
diff --git a/gcore/gdaldataset.cpp b/gcore/gdaldataset.cpp
@@ -2160,6 +2160,7 @@ CPLErr GDALDataset::BuildOverviews(const char *pszResampling, int nOverviews,
                      "panOverviewList[%d] = %d is invalid. It must be a "
                      "positive value",
                      i, panOverviewList[i]);
+            CPLFree(panAllBandList);
             return CE_Failure;
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -2160,6 +2160,7 @@ CPLErr GDALDataset::BuildOverviews(const char *pszResampling, int nOverviews,`
`2160`	`2160`	`"panOverviewList[%d] = %d is invalid. It must be a "`
`2161`	`2161`	`"positive value",`
`2162`	`2162`	`i, panOverviewList[i]);`
	`2163`	`+ CPLFree(panAllBandList);`
`2163`	`2164`	`return CE_Failure;`
`2164`	`2165`	`}`
`2165`	`2166`	`}`