Bugfix/fix symbol validation in Yahoo Finance service (ghostfolio#4472)

dtslvr · web-flow · commit c467c946d428 · 2025-03-22T17:52:16.000+01:00
* Fix symbol validation

* Add test cases
diff --git a/apps/api/src/services/data-provider/data-enhancer/yahoo-finance/yahoo-finance.service.ts b/apps/api/src/services/data-provider/data-enhancer/yahoo-finance/yahoo-finance.service.ts
@@ -170,7 +170,7 @@ export class YahooFinanceDataEnhancerService implements DataEnhancerInterface {
             symbol = quotes[0].symbol;
           }
         } catch {}
-      } else if (symbol?.includes('-')) {
+      } else if (symbol?.endsWith(`-${DEFAULT_CURRENCY}`)) {
         throw new Error(`${symbol} is not valid`);
       } else {
         symbol = this.convertToYahooFinanceSymbol(symbol);
diff --git a/test/import/invalid-symbol-btc-usd.csv b/test/import/invalid-symbol-btc-usd.csv
@@ -0,0 +1,2 @@
+Date,Code,Currency,Price,Quantity,Action,Fee
+12/12/2021,BTC-USD,USD,44558.42,1,buy,0
diff --git a/test/import/ok-btcusd.csv b/test/import/ok-btcusd.csv
@@ -0,0 +1,2 @@
+Date,Code,Currency,Price,Quantity,Action,Fee
+12/12/2021,BTCUSD,USD,44558.42,1,buy,0

Original file line number	Diff line number	Diff line change
`@@ -170,7 +170,7 @@ export class YahooFinanceDataEnhancerService implements DataEnhancerInterface {`
`170`	`170`	`symbol = quotes[0].symbol;`
`171`	`171`	`}`
`172`	`172`	`} catch {}`
`173`		`- } else if (symbol?.includes('-')) {`
	`173`	+ } else if (symbol?.endsWith(`-${DEFAULT_CURRENCY}`)) {
`174`	`174`	throw new Error(`${symbol} is not valid`);
`175`	`175`	`} else {`
`176`	`176`	`symbol = this.convertToYahooFinanceSymbol(symbol);`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+Date,Code,Currency,Price,Quantity,Action,Fee`
	`2`	`+12/12/2021,BTC-USD,USD,44558.42,1,buy,0`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+Date,Code,Currency,Price,Quantity,Action,Fee`
	`2`	`+12/12/2021,BTCUSD,USD,44558.42,1,buy,0`