Skip to content

Commit 0818064

Browse files
Merge pull request opf#15625 from opf/fix-meeting-form-label
2 parents bef745f + da1bfc8 commit 0818064

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

modules/meeting/app/views/meetings/_form.html.erb

+2-2
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ See COPYRIGHT and LICENSE files for more details.
7171
<div class="form--field-container">
7272
<div class="op-tile-block">
7373
<label class="op-tile-block--tile form--radio-button-container -wide"
74-
for="meeting_type_dynamic"
74+
for="meeting_type_StructuredMeeting"
7575
data-test-selector="op-tile-block">
7676
<div class="op-tile-block--content">
7777
<%= styled_radio_button_tag 'meeting[type]',
@@ -94,7 +94,7 @@ See COPYRIGHT and LICENSE files for more details.
9494
</div>
9595
</label>
9696
<label class="op-tile-block--tile form--radio-button-container -wide"
97-
for="meeting_type_classic"
97+
for="meeting_type_Meeting"
9898
data-test-selector="op-tile-block">
9999
<div class="op-tile-block--content">
100100
<%= styled_radio_button_tag 'meeting[type]',

modules/meeting/spec/features/meetings_new_spec.rb

+7
Original file line numberDiff line numberDiff line change
@@ -306,6 +306,13 @@
306306
new_page.set_type "Classic"
307307
new_page.set_title "Some title"
308308

309+
# Ensure we have the correct type labels set up (Regression #15625)
310+
dynamic_button = find_field "Dynamic"
311+
classic_button = find_field "Classic"
312+
313+
expect(page).to have_css("label[for='#{dynamic_button[:id]}']")
314+
expect(page).to have_css("label[for='#{classic_button[:id]}']")
315+
309316
show_page = new_page.click_create
310317

311318
show_page.expect_toast(message: "Successful creation")

0 commit comments

Comments
 (0)