Merge pull request opf#15782 from opf/bug/55507-not-possible-to-add-multiple-projects-at-the-same-time

[#55507] Make it possible to activate custom fields on multiple projects at the same time

https://community.openproject.org/work_packages/55507

Author: akabiru

app/controllers/admin/settings/project_custom_fields_controller.rb

@@ -43,7 +43,7 @@ class ProjectCustomFieldsController < ::Admin::SettingsController
     before_action :prepare_custom_option_position, only: %i(update create)
     before_action :find_custom_option, only: :delete_option
     before_action :project_custom_field_mappings_query, only: %i[project_mappings unlink]
-    before_action :find_link_project_custom_field_mapping, only: :link
+    before_action :find_custom_field_projects_to_link, only: :link
     before_action :find_unlink_project_custom_field_mapping, only: :unlink
     # rubocop:enable Rails/LexicallyScopedActionFilter
 
@@ -75,15 +75,15 @@ def project_mappings
 
     def link
       create_service = ProjectCustomFieldProjectMappings::BulkCreateService
-                         .new(user: current_user, project: @project, project_custom_field: @custom_field,
+                         .new(user: current_user, projects: @projects, project_custom_field: @custom_field,
                               include_sub_projects: include_sub_projects?)
                          .call
 
       create_service.on_success { render_project_list }
 
       create_service.on_failure do
         update_flash_message_via_turbo_stream(
-          message: join_flash_messages(create_service.errors.full_messages),
+          message: join_flash_messages(create_service.errors),
           full: true, dismiss_scheme: :hide, scheme: :danger
         )
       end
@@ -195,8 +195,8 @@ def find_unlink_project_custom_field_mapping
       respond_with_turbo_streams
     end
 
-    def find_link_project_custom_field_mapping
-      @project = Project.find(permitted_params.project_custom_field_project_mapping[:project_id])
+    def find_custom_field_projects_to_link
+      @projects = Project.find(params.to_unsafe_h[:project_custom_field_project_mapping][:project_ids])
     rescue ActiveRecord::RecordNotFound
       update_flash_message_via_turbo_stream(
         message: t(:notice_file_not_found), full: true, dismiss_scheme: :hide, scheme: :danger
@@ -220,7 +220,7 @@ def drop_success_streams(call)
     end
 
     def include_sub_projects?
-      ActiveRecord::Type::Boolean.new.cast(permitted_params.project_custom_field_project_mapping[:include_sub_projects])
+      ActiveRecord::Type::Boolean.new.cast(params.to_unsafe_h[:project_custom_field_project_mapping][:include_sub_projects])
     end
   end
 end

app/forms/projects/custom_fields/custom_field_mapping_form.rb

@@ -37,9 +37,10 @@ class CustomFieldMappingForm < ApplicationForm
           autocomplete_options: {
             openDirectly: false,
             focusDirectly: false,
+            multiple: true,
             dropdownPosition: "bottom",
             disabledProjects: projects_with_custom_field_mapping,
-            inputName: "project_custom_field_project_mapping[project_id]"
+            inputName: "project_custom_field_project_mapping[project_ids]"
           }
         )
 

app/services/project_custom_field_project_mappings/bulk_create_service.rb

@@ -30,10 +30,10 @@
 
 module ProjectCustomFieldProjectMappings
   class BulkCreateService < ::BaseServices::BaseCallable
-    def initialize(user:, project:, project_custom_field:, include_sub_projects: false)
+    def initialize(user:, projects:, project_custom_field:, include_sub_projects: false)
       super()
       @user = user
-      @project = project
+      @projects = projects
       @project_custom_field = project_custom_field
       @include_sub_projects = include_sub_projects
     end
@@ -49,10 +49,12 @@ def perform
     private
 
     def validate_permissions
-      if @user.allowed_in_project?(:select_project_custom_fields, projects)
+      return ServiceResult.failure(errors: I18n.t(:label_not_found)) if incoming_projects.empty?
+
+      if @user.allowed_in_project?(:select_project_custom_fields, incoming_projects)
         ServiceResult.success
       else
-        ServiceResult.failure(errors: { base: :error_unauthorized })
+        ServiceResult.failure(errors: I18n.t("activerecord.errors.messages.error_unauthorized"))
       end
     end
 
@@ -72,23 +74,25 @@ def validate_contract(service_call, project_ids)
     end
 
     def perform_bulk_create(service_call)
-      ProjectCustomFieldProjectMapping.import(service_call.result, validate: false)
+      ProjectCustomFieldProjectMapping.insert_all(
+        service_call.result.map { |model| model.attributes.slice("project_id", "custom_field_id") }
+      )
 
       service_call
-    rescue StandardError => e
-      service_call.success = false
-      service_call.errors = e.message
     end
 
     def incoming_mapping_ids
-      project_ids = projects.pluck(:id)
+      project_ids = incoming_projects.pluck(:id)
       project_ids - existing_project_mappings(project_ids)
     end
 
-    def projects
-      [@project].tap do |projects_array|
-        projects_array.concat(@project.active_subprojects.to_a) if @include_sub_projects
-      end
+    def incoming_projects
+      @projects.each_with_object(Set.new) do |project, projects_set|
+        next unless project.active?
+
+        projects_set << project
+        projects_set.merge(project.active_subprojects.to_a) if @include_sub_projects
+      end.to_a
     end
 
     def existing_project_mappings(project_ids)

spec/services/project_custom_field_project_mappings/bulk_create_service_spec.rb

@@ -36,7 +36,7 @@
 
     context "with a single project" do
       let(:project) { create(:project) }
-      let(:instance) { described_class.new(user:, project:, project_custom_field:) }
+      let(:instance) { described_class.new(user:, projects: [project], project_custom_field:) }
 
       it "creates the mappings" do
         expect { instance.call }.to change(ProjectCustomFieldProjectMapping, :count).by(1)
@@ -49,19 +49,36 @@
     end
 
     context "with subprojects" do
+      let(:projects) { create_list(:project, 2) }
+      let!(:subproject) { create(:project, parent: projects.first) }
+      let!(:subproject2) { create(:project, parent: subproject) }
+
+      it "creates the mappings for the project and sub-projects" do
+        create_service = described_class.new(user:, projects: projects.map(&:reload), project_custom_field:,
+                                             include_sub_projects: true)
+
+        expect { create_service.call }.to change(ProjectCustomFieldProjectMapping, :count).by(4)
+
+        aggregate_failures "creates the mapping for the correct project and custom field" do
+          expect(ProjectCustomFieldProjectMapping.where(project_custom_field:).pluck(:project_id))
+            .to contain_exactly(*projects.map(&:id), subproject.id, subproject2.id)
+        end
+      end
+    end
+
+    context "with multiple projects including subprojects" do
       let(:project) { create(:project) }
       let!(:subproject) { create(:project, parent: project) }
-      let!(:subproject2) { create(:project, parent: subproject) }
 
       it "creates the mappings for the project and sub-projects" do
-        create_service = described_class.new(user:, project: project.reload, project_custom_field:,
+        create_service = described_class.new(user:, projects: [project.reload, subproject], project_custom_field:,
                                              include_sub_projects: true)
 
-        expect { create_service.call }.to change(ProjectCustomFieldProjectMapping, :count).by(3)
+        expect { create_service.call }.to change(ProjectCustomFieldProjectMapping, :count).by(2)
 
         aggregate_failures "creates the mapping for the correct project and custom field" do
           expect(ProjectCustomFieldProjectMapping.where(project_custom_field:).pluck(:project_id))
-            .to contain_exactly(project.id, subproject.id, subproject2.id)
+            .to contain_exactly(project.id, subproject.id)
         end
       end
     end
@@ -80,7 +97,7 @@
     end
 
     let(:project) { create(:project) }
-    let(:instance) { described_class.new(user:, project:, project_custom_field:) }
+    let(:instance) { described_class.new(user:, projects: [project], project_custom_field:) }
 
     it "creates the mappings" do
       expect { instance.call }.to change(ProjectCustomFieldProjectMapping, :count).by(1)
@@ -103,11 +120,39 @@
              })
     end
     let(:project) { create(:project) }
-    let(:instance) { described_class.new(user:, project:, project_custom_field:) }
+    let(:instance) { described_class.new(user:, projects: [project], project_custom_field:) }
 
     it "does not create the mappings" do
       expect { instance.call }.not_to change(ProjectCustomFieldProjectMapping, :count)
       expect(instance.call).to be_failure
     end
   end
+
+  context "with empty projects" do
+    let(:user) { create(:admin) }
+    let(:instance) { described_class.new(user:, projects: [], project_custom_field:) }
+
+    it "does not create the mappings" do
+      service_result = instance.call
+      expect(service_result).to be_failure
+      expect(service_result.errors).to eq("not found")
+    end
+  end
+
+  context "with archived projects" do
+    let(:user) { create(:admin) }
+    let(:archived_project) { create(:project, active: false) }
+    let(:active_project) { create(:project) }
+
+    let(:instance) { described_class.new(user:, projects: [archived_project, active_project], project_custom_field:) }
+
+    it "only creates mappins for the active project" do
+      expect { instance.call }.to change(ProjectCustomFieldProjectMapping, :count).by(1)
+
+      aggregate_failures "creates the mapping for the correct project and custom field" do
+        expect(ProjectCustomFieldProjectMapping.where(project_custom_field:).pluck(:project_id))
+          .to contain_exactly(active_project.id)
+      end
+    end
+  end
 end