Merge pull request opf#18464 from opf/bug/62556-long-text-cf-not-displayed-when-empty

[#62556] Long text CF not displayed when empty

Author: ulferts

app/models/work_package/pdf_export/export/wp/attributes.rb

@@ -46,14 +46,10 @@ def write_attributes!(work_package)
   def write_long_text_field!(work_package, field_id)
     custom_value = work_package.custom_field_values
                                .find { |cv| cv.custom_field.id == field_id && cv.custom_field.formattable? }
-    if custom_value&.value
-      write_long_text_custom_field!(work_package, custom_value.value, custom_value.custom_field.name)
-    end
+    write_long_text_custom_field!(work_package, custom_value.value || "", custom_value.custom_field.name)
   end
 
   def write_long_text_custom_field!(work_package, markdown, label)
-    return if markdown.blank?
-
     write_optional_page_break
     write_long_text_custom_field_label(label)
     write_markdown_field_value(work_package, markdown)

spec/models/work_packages/pdf_export/work_package_to_pdf_spec.rb

@@ -34,7 +34,7 @@
   include Redmine::I18n
   include PDFExportSpecUtils
   let(:type) do
-    create(:type_bug, custom_fields: [cf_long_text, cf_disabled_in_project, cf_global_bool])
+    create(:type_bug, custom_fields: [cf_long_text, cf_empty_long_text, cf_disabled_in_project, cf_global_bool])
   end
   let(:parent_project) do
     create(:project, name: "Parent project")
@@ -65,8 +65,10 @@
              project_custom_field_bool.id => true,
              project_custom_field_long_text.id => "foo"
            },
-           work_package_custom_fields: [cf_long_text, cf_disabled_in_project, cf_global_bool],
-           work_package_custom_field_ids: [cf_long_text.id, cf_global_bool.id]) # cf_disabled_in_project.id is disabled
+           work_package_custom_fields: [cf_long_text, cf_empty_long_text, cf_disabled_in_project, cf_global_bool],
+
+           # cf_disabled_in_project.id not included == disabled
+           work_package_custom_field_ids: [cf_long_text.id, cf_empty_long_text.id, cf_global_bool.id])
   end
   let(:forbidden_project) do
     create(:project,
@@ -78,8 +80,10 @@
            status_code: "on_track",
            active: true,
            parent: parent_project,
-           work_package_custom_fields: [cf_long_text, cf_disabled_in_project, cf_global_bool],
-           work_package_custom_field_ids: [cf_long_text.id, cf_global_bool.id]) # cf_disabled_in_project.id is disabled
+           work_package_custom_fields: [cf_long_text, cf_empty_long_text, cf_disabled_in_project, cf_global_bool],
+
+           # cf_disabled_in_project.id not included == disabled
+           work_package_custom_field_ids: [cf_long_text.id, cf_empty_long_text.id, cf_global_bool.id])
   end
   let(:user) do
     create(:user,
@@ -97,9 +101,12 @@
   let(:image_attachment) { Attachment.new author: user, file: File.open(image_path) }
   let(:attachments) { [image_attachment] }
   let(:cf_long_text_description) { "**foo** *faa*" }
+  let(:cf_empty_long_text_description) { "" }
   let(:cf_long_text) do
-    create(:issue_custom_field, :text,
-           name: "Work Package Custom Field Long Text")
+    create(:issue_custom_field, :text, name: "Work Package Custom Field Long Text")
+  end
+  let(:cf_empty_long_text) do
+    create(:issue_custom_field, :text, name: "Empty Work Package Custom Field Long Text")
   end
   let!(:cf_disabled_in_project) do
     # NOT enabled by project.work_package_custom_field_ids => NOT in PDF
@@ -157,6 +164,7 @@
            description:,
            custom_values: {
              cf_long_text.id => cf_long_text_description,
+             cf_empty_long_text.id => cf_empty_long_text_description,
              cf_disabled_in_project.id => "6.25",
              cf_global_bool.id => true
            }).tap do |wp|
@@ -219,6 +227,7 @@
       "Date", "05/30/2024 - 03/13/2025",
       "Other",
       "Work Package Custom Field Boolean", "Yes",
+      "Empty Work Package Custom Field Long Text",
       "Work Package Custom Field Long Text", "foo   faa",
       "Costs",
       "Spent units", "Labor costs", "Unit costs", "Overall costs", "Budget"
@@ -439,9 +448,10 @@ def get_column_value(column_name)
           end,
           "Custom field boolean", I18n.t(:general_text_Yes),
           "Custom field rich text", "[#{I18n.t('export.macro.rich_text_unsupported')}]",
-          "Custom field hidden",
+
           "1", export_time_formatted, project.name,
 
+          "Custom field hidden",
           "No replacement of:",
           "projectValue:1:status",
           "projectLabel:status",