[pull] dev from opf:dev #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
The CI tries to run it, and produces a syntax error.
- Avoid recomputing % complete when work and remaining work are invalid to avoid having errors on % Complete - Set work when unset and others are set - Set remaining work when unset and others are set - Add more test cases
This commit ensures an accessible experience to users as dictated by the Primer guidelines. The solution for focusing the right field is built in-house as it's not provided out-of-the-box by Primer's form fields at the moment.
This is to ensure that the total work, total remaining work, and total % Complete are always consistent. See https://community.openproject.org/wp/40749 for the detailed specification.
It is 0 by default. This is to ensure that the total work, total remaining work, and total % Complete are always consistent. Without it, we could have Work being set and Remaining work being unset, which is bad for the ancestors totals. See https://community.openproject.org/wp/40749 for the detailed specification.
…ing-work-together Tie work and remaining work together
Remaining work can only be set if work is set first. Also refactored `Pages::WorkPackagesTable` a bit to remove duplicated methods.
By refactoring ProgressEditModal to inherit from EditField. The class has been renamed to ProgressEditField as it is about editing a field rather than the modal itself.
First draft of the specifications of the OpenProject Page Header component
Before, the `done_ratio` journal formatter was :decimal, which would always convert nil to 0. And so unsetting the done_ratio would show as "% Complete changed from 50 to 0". Now it uses a dedicated :percentage formatter, which will render nil as expected and also add a "%" sign at the end of the value. And so unsetting the done_ratio now shows as "% Complete deleted (30%)".
If OPENPROJECT_DISABLE__MIGRATIONS__CHECK is set to 'true', then the pending migrations screen will not be displayed. Useful to test some stuff while working on migrations. But a yellow annoying banner will be displayed in the bottom of OpenProject page instead.
- only for one drive storage configuration - removed previous project folder checkbox
[53811] Documentation of PageHeader
Thanks Klaus! Co-authored-by: Klaus Zanders <klaustopher@users.noreply.github.com>
This avoid having to reenable it later Co-authored-by: Klaus Zanders <klaustopher@users.noreply.github.com>
Co-authored-by: Klaus Zanders <klaustopher@users.noreply.github.com>
Co-authored-by: Klaus Zanders <klaustopher@users.noreply.github.com>
…in-core Bump to primer_view_components 0.28.1 and update PageHeaders in Core
…ct-administration-settings-into-multiple-pages [#51793] Split existing project administration settings into multiple pages
Release notes section for changes in design variables
* don't assign reviewer, as assigning a team requires a PAT Managing (updating) a Personal Access Token seem to much for the little benefit of possibly ignored notifications for review and assigning reviewers individually goes against the idea of making merging releases into dev a team responsibility. * create a temp branch from release branch for pr As PR is created only for conflict resolution, a branch to which dev can be merged is needed and it can't be release branch itself.
…s-to-include-%-complete-values [50965] Add default % Complete for seeded statuses
Code maintenance ticket is https://community.openproject.org/wp/54050.
…he frame re-rendering.
…ing on the frame re-rendering." This reverts commit 714057f.
This reverts commit d0232cd.
Rely on automatic_management_enabled value.
…ations [Op#52449]: Add toggle to unsubscribe/subscribe admins health notifications for a storage
…on-of-percent-complete [#40749] Consistently calculate % Complete in Work Package hierarchies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )