forked from opf/openproject
-
Notifications
You must be signed in to change notification settings - Fork 0
[pull] dev from opf:dev #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… there will be a second scrollbar on the page. The space below the table was removed as well, as it looks weird. When the modal is opened, users might have to scroll (until this not a Primer action menu) but this is accepted as it is an edge case and not visible all the time.
…it's not mandatory
… there is a specific icon
- https://community.openproject.org/wp/53069 - add more icon overrides
- fixed feature spec expectation
- still set to true, as there is a bug crashing the viewer on false
- fixed css glitch in menu tabs
…s been made private https://community.openproject.org/work_packages/53344 This covers an edge case, when an adminitrator makes another user's query private. In this case, the query becomes accessible only by its creator. We will try to reload the query after the save happens, but since the query is not accessible, a confusing error message is rendered. In order to avoid this error message, we are redirecting the admin to the default query page if the query becomes private and not accessible.
…rs-of-new-notifications-has-the-wrong-icon [40147] Snackbar/toast informing users of new notifications has the wrong icon
* remove duplicated arrows in select and keep arrows of primer
It was gone because of the wrong scope in the SASS file. Can be seen for instance in the status edit page, with the % complete select field.
…etry Applied retry_on for ManageNextcloudIntegrationJob
set the correct css selector for styles of an arrow in select
See https://community.openproject.org/wp/54309 And renamed some files and descriptions from "estimated time" to "work".
…-visible [54309] Display total work even when set to 0h
…er-of-the-screen-on-mobile [54307] Show dialogs in the center of the screen on mobile
…ound-the-authorresponsiblepresenter-field [53977] Change placeholder of user autocompleter in agenda item form
See https://community.openproject.org/wp/54299 when setting work or remaining work on a work package, it's odd to see "Total work set to __h" along with "Work set to __h". By not setting totals for "leaf" work packages, we avoid having it displayed in the activity stream.
* set the format for errors and change some error messages * change other error messages * correct capitalization
--- updated-dependencies: - dependency-name: aws-sdk-core dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
… move their mouse too much
…ar-item-is-cut-off-in-the-project-custom-field-dialog [53724] ckEditor paragraph toolbar item is cut off in the project custom field dialog
…ent-3.12.1 build(deps): bump view_component from 3.12.0 to 3.12.1
…ev/openproject/octicons-angular-19.10.0 build(deps): bump @openproject/octicons-angular from 19.9.0 to 19.10.0 in /frontend
…e-3.192.1 build(deps): bump aws-sdk-core from 3.192.0 to 3.192.1
…at-was-created-by-a-deleted-user Bug/53344 cannot modify a query that was created by a deleted user
[54306] Left align the progress modal to the field
…n-admin user edits the attributes https://community.openproject.org/work_packages/53704
…ok and also disable non available custom fields. We have a few callbacks that interfered with the disable_custom_fields_with_empty_values being on the after_create callback. For example the CustomValue model also has an after_create callback activate_custom_field_in_customized_project which overwrites the changes we do in the disable_custom_fields_with_empty_values. This makes all the custom fields with a custom value to be activated, regardless of the changes we do in the disable_custom_fields_with_empty_values. Since we want the disable_custom_fields_with_empty_values to have the final word, it is moved into a before_commit hook, which will be executed after the activate_custom_field_in_customized_project.
…ommit hook and also disable non available custom fields." This reverts commit de85bc6.
This is a compromise solution to avoid further patching the acts as customizable plugin, because it will be removed anyway. This behaviour does not manifest on the UI, so it does not present a real problem.
…5298) * Documentation 14.0: adding files storages permissions explanation Documentation 14.0: adding files storages permissions explanation * Update docs/system-admin-guide/users-permissions/roles-permissions/README.md Co-authored-by: dominic-braeunlein <d.braeunlein@openproject.com> * Update docs/system-admin-guide/users-permissions/roles-permissions/README.md Co-authored-by: dominic-braeunlein <d.braeunlein@openproject.com> * Update docs/system-admin-guide/users-permissions/roles-permissions/README.md Co-authored-by: dominic-braeunlein <d.braeunlein@openproject.com> * Update docs/system-admin-guide/users-permissions/roles-permissions/README.md Co-authored-by: dominic-braeunlein <d.braeunlein@openproject.com> * Update docs/system-admin-guide/users-permissions/roles-permissions/README.md Co-authored-by: dominic-braeunlein <d.braeunlein@openproject.com> --------- Co-authored-by: dominic-braeunlein <d.braeunlein@openproject.com>
* Adding documentation on file storages troubleshooting Adding documentation on file storages troubleshooting * docs link fix * docs link fix * adding file storages health status e-mail documentation * Update docs/system-admin-guide/file-storages/file-storage-troubleshooting/README.md Co-authored-by: dominic-braeunlein <d.braeunlein@openproject.com> * Update docs/system-admin-guide/file-storages/file-storage-troubleshooting/README.md Co-authored-by: dominic-braeunlein <d.braeunlein@openproject.com> * Update docs/system-admin-guide/file-storages/file-storage-troubleshooting/README.md Co-authored-by: dominic-braeunlein <d.braeunlein@openproject.com> * Update docs/system-admin-guide/file-storages/file-storage-troubleshooting/README.md Co-authored-by: dominic-braeunlein <d.braeunlein@openproject.com> * Update docs/system-admin-guide/file-storages/file-storage-troubleshooting/README.md Co-authored-by: dominic-braeunlein <d.braeunlein@openproject.com> * Update docs/system-admin-guide/file-storages/file-storage-troubleshooting/README.md Co-authored-by: dominic-braeunlein <d.braeunlein@openproject.com> * Update docs/system-admin-guide/file-storages/file-storage-troubleshooting/README.md Co-authored-by: dominic-braeunlein <d.braeunlein@openproject.com> * Update docs/system-admin-guide/file-storages/file-storage-troubleshooting/README.md Co-authored-by: dominic-braeunlein <d.braeunlein@openproject.com> * Update docs/system-admin-guide/file-storages/file-storage-troubleshooting/README.md Co-authored-by: dominic-braeunlein <d.braeunlein@openproject.com> * Update README.md * Update docs/system-admin-guide/file-storages/file-storage-troubleshooting/README.md Co-authored-by: dominic-braeunlein <d.braeunlein@openproject.com> --------- Co-authored-by: dominic-braeunlein <d.braeunlein@openproject.com>
…tribute-values-are-deleted-when-a-non-admin-user-edits-the-attributes [#53704] Visible=false project attribute values are deleted when a non-admins edit the attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )