[pull] dev from opf:dev #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
- Use correct progress terminology in test description. - Merge tests changing work and remaining work: the tests setup and expectations where the same. Only the action differed: one was calling the service with `estimated_hours` being modified, the other with `remaining_hours` being modified. - Make tests faster (from 13 secs to 5 secs) - Introduce `shared_let_work_packages` to create work packages with table helpers in a `shared_let` fashion. - Introduce `for_each_context` which runs the same set of tests with different RSpec shared contexts.
The leaves are no more used in `UpdateAncestorsService`.
See: https://gitlab.com/gitlab-org/ruby/gems/gitlab-chronic-duration Really nice gem to handle parsing and outputting durations in multiple units.
Missing dependency in `package-lock.json`
This file is sourced from Gitlab's Rails application and provided as `.js`. We therefore don't want to enforce eslint rules on it to keep it prisitine with its upstream source.
The job has been updated to excluded work packages having a status with `excluded_from_totals` set to true. The journal entry has valid values so that the cause renders correctly. The job is not yet triggered properly when the "excluded from totals" attribute of a status is changed in the administration.
Use 2 custom matchers to test rendering. It avoids creating contexts to set different values fro `html`. The rspec output with documentation formatter also looks nicer.
The column headers of the statuses page have a shorter text to fit a reasonable page width.
- Update the messages according to latest specification - Update the journal cause to handle multiple changes in one cause
It's to prevent silly mistakes when writing and copy-pasting tables in specs.
…-misplaced-on-hover [#52670] rework main menu resizer
…ration-input-is-invalid [#55431] Display an inline error when duration input is not a duration
… add missing icons"
…7-replace-webfonts-generator-package-and-add-missing-boxed-icons Revert "Code maintenance/55267 replace webfonts generator package and add missing icons"
…ub-headers-in-pages-where-the-pageheader-is-already-used [52586] Include the sub-headers in pages where the PageHeader is already used
Revert "Sync `package-lock.json` with `package.json`"
…e-attributes-in-pdf-export [#54377] Embedded work package attributes in PDF export
…tential-data-loss-when-changing-progress-calculation-modes [55467] Warn about potential data loss when changing progress modes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )