[pull] dev from opf:dev #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…ects So that instead of rendering the dialog, an error flash will be shown if the storage is not configured properly. https://community.openproject.org/work_packages/56599
https://community.openproject.org/work_packages/54122 Previously, the sorting was done on the "name" attribute, which actually just is the gitlab_id saved as a string. So after 10 pipelines, the sorting was wrong.
When test is finished, Capybara calls `Capybara.reset!` which in turn calls `driver.reset!`. This one is responsible for stopping the browser by navigating to about:blank page and waiting for pending requests to complete. With Cuprite, we observed that some requests could still be triggered from the browser after `Capybara.reset!` is called. It can interfere with test execution is some unexpected ways: when a request to the API is made, the settings are read from the database. If this happens right when the database is being rolled back to a previous savepoint (which happens when using `before_all` helper), then in postgres dapater code there is a `nil` reference instead of a result, and then it errs with "NoMethodError: undefined method 'clear' for nil". You can run tests from `spec/features/work_packages/progress_modal_spec.rb` a couple of times to experiment the error. It happens mostly with tests having the most nested `before_all` calls. We tried navigating to about:blank with Cuprite, but some requests were still made. So we looked for another fix. Using a middleware to actively block requests outside of test execution fixed the issue.
…ests_outside_of_test Block browser requests made outside of feature tests
…from the other custom fields
…hrasing-of-required-and-visible-options [#55299] Project attributes: Fix phrasing of "required" and "visible" fields
…g needed to be canceled out.
- https://community.openproject.org/work_packages/40942 - resolved old todo about redirect of deprecated API endpoint - introduced deprecation round for /api/v3/work_packages/:id/relations - updated api specification docs
…creating-work-package-relations [#40942] documented API behaviour for relation creation
Bumps [@ng-select/ng-select](https://github.com/ng-select/ng-select) from 13.5.0 to 13.7.0. - [Release notes](https://github.com/ng-select/ng-select/releases) - [Changelog](https://github.com/ng-select/ng-select/blob/master/CHANGELOG.md) - [Commits](ng-select/ng-select@v13.5.0...v13.7.0) --- updated-dependencies: - dependency-name: "@ng-select/ng-select" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…g-agenda-and-meeting [22517] PDF export of meeting agenda and meeting
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom) from 1.6.9 to 1.6.10. - [Release notes](https://github.com/floating-ui/floating-ui/releases) - [Changelog](https://github.com/floating-ui/floating-ui/blob/master/packages/dom/CHANGELOG.md) - [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.6.10/packages/dom) --- updated-dependencies: - dependency-name: "@floating-ui/dom" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Follow up modification for the WP: https://community.openproject.org/work_packages/55299
…hrasing-of-required-and-visible-options [#55299] Update Project attributes searchable hint text
…e-picker-for-the-existing-folders-with-manually-managed-permissions-in-the-dialog [#55967] Implement file picker for the existing folders with manually managed permissions in the dialog
…t-project-folder-button-in-context-menu [#56284] Implement "Edit project folder" button in context menu
…bove-the-editor-toolbar [56921] Description text shown above the editor toolbar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )