[pull] dev from opf:dev #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Consequently attempt to simplify the observable structure: hasReminder$ should emit based if notificationCountChanged$ | reminderModalUpdated$ emit i.e. if there's a new notification (from polling) or when the reminder modal is closed we want to recheck the reminderCount and subsequently update the icon
Bumps [googleauth](https://github.com/googleapis/google-auth-library-ruby) from 1.12.0 to 1.12.1. - [Release notes](https://github.com/googleapis/google-auth-library-ruby/releases) - [Changelog](https://github.com/googleapis/google-auth-library-ruby/blob/main/CHANGELOG.md) - [Commits](googleapis/google-auth-library-ruby@googleauth/v1.12.0...googleauth/v1.12.1) --- updated-dependencies: - dependency-name: googleauth dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [fog-aws](https://github.com/fog/fog-aws) from 3.29.0 to 3.30.0. - [Changelog](https://github.com/fog/fog-aws/blob/master/CHANGELOG.md) - [Commits](fog/fog-aws@v3.29.0...v3.30.0) --- updated-dependencies: - dependency-name: fog-aws dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [httpx](https://gitlab.com/os85/httpx) from 1.3.4 to 1.4.0. - [Commits](https://gitlab.com/os85/httpx/compare/v1.3.4...v1.4.0) --- updated-dependencies: - dependency-name: httpx dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Instead of expecting modules to selectively overwrite methods of this class, we offer an explicit extension point where replacements can be registered explicitly. Thus patching the implementation is not necessary anymore, instead it can be configured from initializers.
build(deps): bump fog-aws from 3.29.0 to 3.30.0
…setting-reminders Feature/59793 Add new icons for setting reminders `op-alarm` & `op-alarm-set`
build(deps): bump httpx from 1.3.4 to 1.4.0
…1.12.1 build(deps): bump googleauth from 1.12.0 to 1.12.1
There is now add_replacements which accepts a hash, allowing to add multiple replacements in one call. This should make mass-adding replacements look less bulky. Also including helpers to ActsAsOpEngine to make adding replacements from a module nicer.
- https://community.openproject.org/work_packages/59998 - do not show tab "subject configuration" if feature flag is not active
…ting-to-send-an-email-reminder-immediately implementation/59815 Add email setting to send an email reminder immediately
[#59998] add feature flag for work package subject configuration
Refactor ReplaceReferencesService
New folder button
#17504) https://community.openproject.org/work_packages/60342 Reminder email template will be redesigned to differentiate from notifications. In the meantime, we add the note or work package subject in the email subject as a tiny enhancements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )