[pull] dev from opf:dev #346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Storing tokens in the database to have them available for requests to third parties (e.g. Nextcloud) later. The OIDC session is now marked as optional, since the session link is also used to store access and refresh tokens associated with the session. Those tokens might be present, even if the session id (which belongs to the optional OIDC Back-Channel Logout specification) is missing.
This commit provides an alternative implementation for storing tokens compared to the parent commit. The idea is that we will not only need to store access and refresh tokens obtained via Omniauth, but also the ones to access third party services that will most likely be obtained through OAuth 2.0 Token Exchange. This structure allows to store all of these tokens in the same data model, while keeping the implementation separated from the back-channel logout logic.
Doing so hopefully simplifies token handling a bit. It's now not required to pass specific sessions into services as long as a user is passed. This theoretically also enables us to act in the name of a user from a background job, though we have no specific plans for that yet. A possible downside is, that we now require being handed long-term tokens (i.e. tokens with offline_access scope). On the other hand, we'd have had to consider keeping our tokens fresh for the previous implementation, which we also didn't solve yet.
Those places were noticed by Rubocop after rebasing a feature branch onto the dev branch.
…atabase Save OIDC tokens to OpenProject database
…-duplicate-folder-name-is-not-accurate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )