Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] dev from opf:dev #348

Merged
merged 51 commits into from
Jan 14, 2025
Merged

[pull] dev from opf:dev #348

merged 51 commits into from
Jan 14, 2025

Conversation

pull[bot]
Copy link

@pull pull bot commented Jan 14, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

oliverguenther and others added 30 commits January 13, 2025 09:44
Wait for grid to be updated before initializing widget
FeedbackDialog slot names have been updated to be consistent with the DangerConfirmationDialog.

https://community.openproject.org/work_packages/60359
…og-component-slots

[#60359] Update FeedbackDialog slot names
* when creating a new WP  we want to show the form in edit mode due to focus on elements, but we dont need to show confirmation after creating it

* any time that we press on create button it adds a new instance of edit form component, so we just check the conditions if the current element is in the dom, not for other available instances

* a hacky fix to remove inactive components in constructor

* move the removing inactive elemnts to the listener callback
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.69.2 to 1.70.0.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.69.2...v1.70.0)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [lefthook](https://github.com/evilmartians/lefthook) from 1.10.3 to 1.10.4.
- [Release notes](https://github.com/evilmartians/lefthook/releases)
- [Changelog](https://github.com/evilmartians/lefthook/blob/master/CHANGELOG.md)
- [Commits](evilmartians/lefthook@v1.10.3...v1.10.4)

---
updated-dependencies:
- dependency-name: lefthook
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
build(deps-dev): bump rubocop from 1.69.2 to 1.70.0
…10.4

build(deps-dev): bump lefthook from 1.10.3 to 1.10.4
@pull pull bot added the ⤵️ pull label Jan 14, 2025
@pull pull bot merged commit 9b1642f into kp-forks:dev Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants