forked from opf/openproject
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] dev from opf:dev #354
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CSS change came from #8755. The CSS fix seems not to be needed anymore, as removing this CSS does not re-introduce the bug marked in the WorkPackage
…es instead of 8minutes 15seconds
This way the live example can be accessed from the previews library too, and not just from the form pattern documentation.
Previously we only checked internal linking inside the documentation for consistency. Now there is also a basic test to see whether links from OpenProject into the documentation are pointing to a valid page. I used this opportunity to move the static links into a Yaml file. This made it easier to load the list of static links for the check as well and it removed a long data object from the Ruby code.
One of them was not used anymore (the page was probably replaced by two other pages), while the other one was properly redirected on our website, so we now simply avoid the redirect.
…sing. Update docs.
…umentation Add form preview documentation and create a generic form preview controller
…nt.html.erb Co-authored-by: Oliver Günther <o.guenther@openproject.com>
Also check static links for consistency
…-time-dialog [#59037] Primerize "Log time" dialog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )