[pull] dev from opf:dev #422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Use @-mention of user when quote replying to a comment
The idea is that now there is a central class (a Wizard) managing the steps necessary to guide the user through creation of a new storage. This avoids problems such as the update action of step A being required to prepare some parts of step B already, so that the view/component for step B can be rendered correctly. Since the same components are used inside and outside of the step-by-step wizard, we are explicitly transferring the state on whether we are currently in a wizard via parameters. This results in some degree of boilerplate, but is hopefully more clear than guessing based on context, whether or not we should show the next step after submission or go back to regular edit mode.
The storage view component now has no own "opinion" on the display order and grouping of steps anymore, but will merely reflect the wizard configuration. Changes in the wizard are immediately reflected in the UI as well. Selection of the right components was also extracted into the storage registries. Renamings of existing translations were in most cases avoided, by renaming wizard steps according to existing translations. This made it necessary to unify the instantiation of all components rendered inside the storage view, which was relatively straight-forward for most of them. The OAuthClientFormComponent was challenging, as there was one use case where it needed to be initialized with a client that was not yet assigned to the storage.
All of these shared some common patterns that were always repeated, so it made sense to unify them in a common base class. For the info components this also affected inclusion of the StorageViewInformation module, which is why I promoted this module to be the new superclass for these components. Closer inspection will probably reveal more commonalities that can be moved upwards in the class hierarchy.
Refactor the step-by-step storage setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )