[pull] dev from opf:dev #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
https://community.openproject.org/wp/62580 The contract class being used was always `WorkPackages::CreateContract`. It needs to be `WorkPackages::UpdateContract` when the user edits fields so that the correct permissions are checked.
We found some failing tests due to frozen string literals. In one case it made sense to explicitly mark the starting string as non-frozen, because we repeatedly add content to it.
As a side-find, replacing usage of "vanilla" rand with SecureRandom.rand, to ensure that the token is generated from a properly randomized source and making sure that all intended characters (0-9) are used, not forgetting about the nine.
Frozen string compatibility & mobile OTP fixes
Fix auto-linking custom protocols
…et-of-permissions-sees-error-when-updating-wp-progress [62580] Fix read-only error displayed when editing progress values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )