[pull] dev from opf:dev #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
ActiveSupport deep_merge does not concatenate arrays from different hashes. Relations were stored as an array. Switch to a hash to store all relations without any loss.
https://community.openproject.org/wp/62557 Date picker tabs and relations tab are now sharing the same code for ordering the relations so there should not be any difference about it now.
Instead of using parameters given to the RelationComponent.
Failing spec is `./modules/meeting/spec/features/structured_meetings/structured_meeting_crud_spec.rb:90` in job https://github.com/opf/openproject/actions/runs/14190043033/job/39752454726 When reordering agenda items, the order is not updated immediately under high load. If the action menu is opened before the reordering is finished, the action menu will close when the items are reordered and clicking on the item "Agenda item" will fail. The flaky spec is fixed by waiting for the order to be updated with `assert_agenda_order!`.
Also: - Precompute the closest relation in the `RelationGroup` constructor to avoid recomputing it every time. - Move the `closest?` information in the `RelationItem` instance directly to remove its computation from the component.html logic.
https://community.openproject.org/wp/62607 The order of the relation groups was not consistent from one work package to another. It's because the relations are returned in any order from the database. Instead of getting relations from database and then grouping them by type as they come up in the array, get the types in the order we want and build up the relation groups from there. There are no differences between rendering a `RelationGroup` of type child and a `RelationGroup` of type relation anymore. For this to happen, the "children" type had to be renamed "child", which is in line with the Relation::TYPE_CHILD constant.
Example usage: | subject | successors | | predecessor2 | main, predecessor with lag 2 | | predecessor | precedes main | | main | |
Bumps [lefthook](https://github.com/evilmartians/lefthook) from 1.11.5 to 1.11.6. - [Release notes](https://github.com/evilmartians/lefthook/releases) - [Changelog](https://github.com/evilmartians/lefthook/blob/master/CHANGELOG.md) - [Commits](evilmartians/lefthook@v1.11.5...v1.11.6) --- updated-dependencies: - dependency-name: lefthook dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…date field "reset" button works in Safari
user_id is already covered by a different index, so there is no need for this one. origin_user_id is an index that will never be used, because we do not query for the origin_user_id ever.
Most notable is that computation of closest relation has been moved to the ClosestRelation class. Co-authored-by: Alexander Brandon Coles <a.coles@openproject.com>
…d-children-tabs-do-not-show-the-correct-chronological-order [62557] date picker successor and children tabs must show the same correct chronological order
Bump primer 0.59.0
…ookbook Remove some deprecated lookbook previews
…11.6 Bump lefthook from 1.11.5 to 1.11.6
Update remote identity indices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )