[pull] dev from opf:dev #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…and heading description
Co-authored-by: Ivan Kuchin <i.kuchin@openproject.com>
rename end_date/end_gate to finish_date/finish_gate
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.18.6 to 1.18.7. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.18.6...v1.18.7) --- updated-dependencies: - dependency-name: nokogiri dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
on spec `./spec/features/users/index_spec.rb:72` on job https://github.com/opf/openproject/actions/runs/14200641973/job/39786500702 Failure/Error: expect(rows.map(&:text)).to include(*users.map(&:login)) expected [] to include "bob1" # ./spec/support/pages/admin/users/index.rb:41:in 'Pages::Admin::Users::Index#expect_listed' # ./spec/features/users/index_spec.rb:115:in 'block (3 levels) in <top (required)>' I suppose the UI was not updated with the filtered content despite the previous command `filter_by_status` having a `wait_for_network_idle` in it. By adding a `count` parameter to the `page.all` call, it will wait until the count matches the expected count, which should fix the flakiness seen.
…erty-of-phase Rework life cycle data structure
…index-spec Fix flaky spec
The endpoint filtered against, /api/v3/principals, already has the visible scope attached to it. Therefore, no non visible principals can be retrieved anyway. Handing in the ids from the client does not provide additional filtering.
…e-in-project-list-filters-in-instances-with-many-users avoid long list of ids in filter
…18.7 Bump nokogiri from 1.18.6 to 1.18.7
…d to user custom field strategies to use the user autocompleter for user custom fields.
Fixes for Custom Actions administration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )