[pull] dev from opf:dev #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
https://community.openproject.org/wp/62595 Idiomorph is used to morph the date picker dialog content, except the active element. When clicking the date button in Safari, it does not become the active element because it's actually a link, and for some reason links cannot be active in Safari. What becomes active instead is the closest focusable parent element. It is the whole `panel-wp-datepicker-dialog--content-tab--dates` as it has `tabindex: 0`. As idiomorph does not change the active element, that's why the date fields stayed the same. To fix this, we make pass `ignoreActiveValue = true` to idiomorph only if the active element is an input. This way the whole date picker form is always updated when no input is focused. It also fixes similar issues that existed on "Today" links and "Working days only" checkbox too. The `data: { skip_morphing: true }` is some dead code leftover that is no longer used.
Saw some errors in the console from `prepareInputFieldsForSafari` method: startDateField and dueDateField are undefined when the blank slate is displayed when a work package cannot be switched to automatic. Fixed the error by fixing type declarations of `startDateField`, `dueDateField` and `durationField` in `PreviewController` and fix resulting errors.
…n-single-date-mode-on-date-picker-on-safari [62595] Fix date buttons not opening input in Safari in date picker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )