[pull] dev from opf:dev #553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
https://community.openproject.org/wp/62891 For an automatically scheduled successor, when "Working days only" is turned off and the day before the start date is a non-working day, the start will shift to an earlier date. Multiple things need to work correctly: - The start date must be recalculated and displayed in the date picker. - The mini calendar of the date picker need to have enabled dates updated, as the start date has changed. - If the due date was not set manually, duration must be kept and due date will be recalculated. - If the due date was set manually, it must not be changed and duration will be recalculated. - If the due date was unset manually, it must remain unset and duration must be unset too. Also the lag calculation was partly incorrect: it was adding non-working days when "Working days only" was on, and days when "Working days only" was off. This has been fixed: lag is always about working days regardless of the successor "Working days only" setting. https://community.openproject.org/wp/63152 When the browser timezone offset is negative, the enabled dates in the date picker for an automatically scheduled successor were not correct: the date before the start date was enabled. This is now fixed.
There was a bug in previous versions where the lag was all-days when successor's ignore_non_working_days was true, leading to a start being too early. The correct behavior for lag is to be working days only, even if the successor ignores non-working days. The set attributes service must be able to fix these wrong dates so that the date picker does not open with an error message saying that the start date is too early (especially as the start date cannot be changed).
…e-custom-fields-are-null [#62444] Webhook embedded resource custom fields are null
That's how it was working before, and it was changed with the work done on #62891. This has been restored. Also remove the need to force touching the start date in date picker when the work package is scheduled automatically: it's not needed anymore as the start date is always recalculated when in automatic mode. Plus it was causing issues when switching back and forth between scheduling mode as the start date would stick instead of being recalculated.
…down-in-the-meetings-subheader-doesn-t-not-properly-right-align-with-the-button [63014] The "Create meeting" drop down in the Meetings subheader doesn't not properly right-align with the button
Fix footer for past recurring meetings
#18593) * [#62768] Automatic scheduling mode: make it possible to enter Finish date by direct input or by clicking on the mini calendar https://community.openproject.org/work_packages/62768 [#62768] Automatic scheduling mode: make it possible to enter Finish date by direct input or by clicking on the mini calendar https://community.openproject.org/work_packages/62768 * Simplified phrasing --------- Co-authored-by: Parimal Satyal <88370597+psatyal@users.noreply.github.com>
…#18592) * [#62769] Add % Complete to work package table sums https://community.openproject.org/work_packages/62769 [#62769] Add % Complete to work package table sums https://community.openproject.org/work_packages/62769 * update * update
…#18567) [#62770] Link to application schemes https://community.openproject.org/work_packages/62770 [#62770] Link to application schemes https://community.openproject.org/work_packages/62770
…#18604) [#62761] 15.5 relations changes https://community.openproject.org/work_packages/62761 [#62761] 15.5 relations changes https://community.openproject.org/work_packages/62761
…#18560) * [#62771] Classic meetings sunsetting https://community.openproject.org/work_packages/62771 [#62771] Classic meetings sunsetting https://community.openproject.org/work_packages/62771 * changing screenshots * updated screenshots
https://community.openproject.org/wp/63296 A work package being a child of another package needs to consider both its own soonest start and its new parent soonest start, and take the max of both. Old parent soonest start is not relevant.
…ween-automatic-scheduling-icon-and-date-in-work-package-macro-in-ckeditor [63352] Insufficient spacing between automatic-scheduling icon and date in work package macro in CkEditor
#18550) * [#62772] Project settings: Harmonise "enabled in project" for Types and Custom fields https://community.openproject.org/work_packages/62772 [#62772] Project settings: Harmonise "enabled in project" for Types and Custom fields https://community.openproject.org/work_packages/62772 * fix links * update --------- Co-authored-by: as-op <a.sandorf@openproject.com>
It was not using our datepicker helper which has all the required synchronization logic. Using it fixes the flickering. Failing spec is `./spec/features/work_packages/table/scheduling/manual_scheduling_spec.rb:48` CI job run is https://github.com/opf/openproject/actions/runs/14405034091/job/40403247708?pr=18612
[61807] Gantt chart and relations tab are not synchronized
* fix docs typo * Update README.md
…threshold [62650] Increase threshold for focusing duration
Failing spec is 'spec/features/work_packages/scheduling/automatic_scheduling_logic_spec.rb:340' CI job run is https://github.com/opf/openproject/actions/runs/14442271942/job/40494880063?pr=18613 The spec was failing because the action menu was not visible (maybe it was hidden by a relations tab refresh). The fix is to retry the action until it works.
… an error to be raised
…kages-datepickercontroller-show [62823] NoMethodError in WorkPackages::DatePickerController#show
…-can-be-saved-but-doesn-t-stick [62891][63152] Recalculate start date correctly when toggling "Working days only"
…ting-parent-child-relationship [63296] Fix date error when creating parent-child relationship
…ckages-in-the-calendar [62992] Show single date work packages in the calendar
…sectioncomponent [62754] Document CollapsibleSection
…from-activerecord-recordnotfound [#63386] Use rescue_from ActiveRecord::RecordNotFound
Bumps [@ng-select/ng-select](https://github.com/ng-select/ng-select) from 14.2.8 to 14.5.6. - [Release notes](https://github.com/ng-select/ng-select/releases) - [Changelog](https://github.com/ng-select/ng-select/blob/master/CHANGELOG.md) - [Commits](ng-select/ng-select@v14.2.8...v14.5.6) --- updated-dependencies: - dependency-name: "@ng-select/ng-select" dependency-version: 14.5.6 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Merge release/15.5 into dev
…ev/ng-select/ng-select-14.5.6 Bump @ng-select/ng-select from 14.2.8 to 14.5.6 in /frontend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )