forked from opf/openproject
-
Notifications
You must be signed in to change notification settings - Fork 0
[pull] dev from opf:dev #580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relations tab now shows the parent in addition to other relations. Correctly update the relations count when a parent is added or removed.
Flaky specs are ./spec/features/work_packages/details/relations/hierarchy_spec.rb:153 and ./spec/features/work_packages/details/relations/hierarchy_spec.rb:62 in job run https://github.com/opf/openproject/actions/runs/14590935178/job/40925830680 It looks like throttleTime(1000) "eats" some events, meaning some parts of the UI are not refreshed. By adding `trailing: true`, it sends the last event received during the 1000ms throttle window, if any.
https://community.openproject.org/wp/38030 When clicking the three dots menu of the parent relation item and selecting "Delete relation".
Instead of rendering child menu items, and then relation menu items, render a list of relation types inside a menu. This will be useful when adding the "Parent" item between "Successor (after)" and "Duplicates" items. It also makes the code more declarative.
Reuse the same controller that was used for adding children, `WorkPackageChildrenRelationsController`, and renamed it to `WorkPackageHierarchyRelationsController`. The difference is done with a `relation_type` parameter which can be `"parent"` or `"child"`. Reuse the same dialog that was used for adding children, `AddWorkPackageChildDialogComponent`, and renamed it to `AddWorkPackageHierarchyDialogComponent`.
Now that a parent relation can be added, a milestone work package could have the "Add relation" button in the relations tab because even if it can not have children, the parent can be set.
Bump octicons to 19.25.0
#62693 updated docker slim/aio/compose #62694 provide PostgreSQL 17 upgrade guides for Helm chart
…elations [38030] Add parent relation to relations tab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )