Skip to content

[pull] dev from opf:dev #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Apr 28, 2025
Merged

[pull] dev from opf:dev #580

merged 19 commits into from
Apr 28, 2025

Conversation

pull[bot]
Copy link

@pull pull bot commented Apr 28, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

cbliard and others added 19 commits April 18, 2025 16:24
Relations tab now shows the parent in addition to other relations.
Correctly update the relations count when a parent is added or removed.
Flaky specs are ./spec/features/work_packages/details/relations/hierarchy_spec.rb:153
and ./spec/features/work_packages/details/relations/hierarchy_spec.rb:62
in job run https://github.com/opf/openproject/actions/runs/14590935178/job/40925830680

It looks like throttleTime(1000) "eats" some events, meaning some parts
of the UI are not refreshed. By adding `trailing: true`, it sends the
last event received during the 1000ms throttle window, if any.
https://community.openproject.org/wp/38030

When clicking the three dots menu of the parent relation item and
selecting "Delete relation".
Instead of rendering child menu items, and then relation menu items,
render a list of relation types inside a menu. This will be useful when
adding the "Parent" item between "Successor (after)" and "Duplicates"
items.

It also makes the code more declarative.
After adding a parent and 2 children, the relations count is 3, not 2.
Reuse the same controller that was used for adding children,
`WorkPackageChildrenRelationsController`, and renamed it to
`WorkPackageHierarchyRelationsController`. The difference is done with a
`relation_type` parameter which can be `"parent"` or `"child"`.

Reuse the same dialog that was used for adding children,
`AddWorkPackageChildDialogComponent`, and renamed it to
`AddWorkPackageHierarchyDialogComponent`.
Now that a parent relation can be added, a milestone work package could
have the "Add relation" button in the relations tab because even if it
can not have children, the parent can be set.
#62693 updated docker slim/aio/compose

#62694 provide PostgreSQL 17 upgrade guides for Helm chart
…elations

[38030] Add parent relation to relations tab
@pull pull bot added the ⤵️ pull label Apr 28, 2025
@pull pull bot merged commit 98afc32 into kp-forks:dev Apr 28, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants