[pull] dev from opf:dev #609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
https://community.openproject.org/wp/60580 When multiple CKEditor instances are on the same form, each of them intercepts the submit event and submit the form, leading to multiple identical parallel submit requests. This happens for instance on the bulk edit page when the work packages have long text custom fields because this adds a ckeditor in the form. The form is submitted multiple times and only one request will succeed, the other will produce a 500. That's why a 500 error is sometimes visible on bulk edit. The fix is to track the "in-flight" state per form in a variable shared with all instances of the component instead of storing it in an instance variable.
- label must be cast to lowercase for search matches
…eeting-outcome [#62689] Long code block breaks meeting outcome
…#18876) * [#63799] 16.0 PDF export changes https://community.openproject.org/work_packages/63799 [#63799] 16.0 PDF export changes https://community.openproject.org/work_packages/63799 * [#63799] 16.0 PDF export changes https://community.openproject.org/work_packages/63799 * Update docs/user-guide/work-packages/exporting/README.md Co-authored-by: Andrej Sandorf <77627197+as-op@users.noreply.github.com> --------- Co-authored-by: Andrej Sandorf <77627197+as-op@users.noreply.github.com>
Once the XML contains multiple certificates, the metadata hash has a nil idp_cert. The idp_cert_multi key is always populated. However, we never tried parsing data from there, so it was lost. The way that the Saml::Provider right now represents multiple certificates is to concatenate them inside the idp_cert, so the metadata parsing has been adapted to use that.
…al comments feature is disabled (#18856) On wp comment form submit end, safely toggle internal comment state https://community.openproject.org/wp/63897 When the Internal comments feature is disabled, the internalCommentCheckboxTarget does not exist, causing a warning from Stimulus; the InternalCommentController listens to form submit end events from the activities IndexController which manages comment form submission- it is then able to update the UI state on form close. E.g. Ensuring that the background color is reset e427094
fix upsell page
Fix parsing of multiple certificates from metadata
[chore] fix pattern attribute matcher
…diting-work-packages [60580] Fix error 500 when bulk editing work packages
Use enterprise test chargebee site for pullpreview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )