[pull] dev from opf:dev #623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Bumps [@types/lodash](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/lodash) from 4.17.16 to 4.17.17. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/lodash) --- updated-dependencies: - dependency-name: "@types/lodash" dependency-version: 4.17.17 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…ble-when-clicking-the-arrows Bump primer to 0.66.2
This version adds official support for token exchange, so we can drop usage of preview features.
Upgrade development Keycloak to 26.2
…ev/types/lodash-4.17.17 Bump @types/lodash from 4.17.16 to 4.17.17 in /frontend
…ges (#17920) * check if there is a screen reader active on page load * hide the flat picker for screen readers * make the banner focusable * change the focus color in banner * change disabled to readonly input fields * change replace_via_turbo_stream to add a message to it * add live region of github to out project * add a method to send the aria message * make it possible to pass the attributes * pass type of aria live region to front-end based on the action * remove focused field from date picker * focus on tabs when there is no banner * Revert "remove focused field from date picker" This reverts commit ab5e306. * focus on the first element when opening the dialog * remove auto-focus * undo changes for adding a message * add a new input method for adding a date and select today as a date * remove label and name from form input * change readonly to disabled * undo changes for date-form * delete dateform file * add aria-live for fields in date pickr * add a turbo stream to the component to load the messages for aria live regions * undo changes for check f there is an active screen reader * use settimeout instead of add event listener, so turbo frame also can be used hare * undo changes for text with link form input * remove text with link form input * add documentation for aria-live region * add an example for using current method in relation creation * add aria live region in date-pickr dialog * add some delay for polite messages to make sure it is caught * send a message to be gotten by screen reader in date picker while changing inputs * remove aria-live form inputs in date pickr * show update message after any change in inputs of date picker * fix rubocup errors in relation controller * fix rubocup errors in datepicker controller * fix eslint error * update docs * add some details to the aria live doc * remove test for aria-live on inputs of date pickr * remove unnecessary live region polite for date picker * Update lookbook/docs/patterns/18-aria-live.md.erb Co-authored-by: Henriette Darge <h.darge@openproject.com> * Update lookbook/docs/patterns/18-aria-live.md.erb Co-authored-by: Henriette Darge <h.darge@openproject.com> * fix comment in preview controller * remove role: alert * set correct value for target * move aria turbo stream below live region * add missing spaces and a better headline for js handling turbo aria action * move the exception of modals and dialogs to the end of doc file * Update lookbook/docs/patterns/accessibility/18-aria-live.md.erb Co-authored-by: Alexander Brandon Coles <a.coles@openproject.com> * Update frontend/src/turbo/aria-stream-action.ts Co-authored-by: Alexander Brandon Coles <a.coles@openproject.com> * Update lookbook/docs/patterns/accessibility/18-aria-live.md.erb Co-authored-by: Alexander Brandon Coles <a.coles@openproject.com> * Update app/controllers/work_packages/date_picker_controller.rb Co-authored-by: Alexander Brandon Coles <a.coles@openproject.com> * Update lookbook/docs/patterns/accessibility/18-aria-live.md.erb Co-authored-by: Alexander Brandon Coles <a.coles@openproject.com> * Update app/controllers/concerns/op_turbo/component_stream.rb Co-authored-by: Alexander Brandon Coles <a.coles@openproject.com> * Update app/controllers/work_packages/date_picker_controller.rb Co-authored-by: Alexander Brandon Coles <a.coles@openproject.com> * Update app/controllers/work_packages/date_picker_controller.rb Co-authored-by: Alexander Brandon Coles <a.coles@openproject.com> * Update lookbook/docs/patterns/accessibility/18-aria-live.md.erb Co-authored-by: Alexander Brandon Coles <a.coles@openproject.com> * Update lookbook/docs/patterns/accessibility/18-aria-live.md.erb Co-authored-by: Alexander Brandon Coles <a.coles@openproject.com> * Update lookbook/docs/patterns/accessibility/18-aria-live.md.erb Co-authored-by: Alexander Brandon Coles <a.coles@openproject.com> * Update lookbook/docs/patterns/accessibility/18-aria-live.md.erb Co-authored-by: Alexander Brandon Coles <a.coles@openproject.com> * change parameter in update_inputs_aria_live_message string * change type to politeness * Update lookbook/docs/patterns/accessibility/18-aria-live.md.erb Co-authored-by: Alexander Brandon Coles <a.coles@openproject.com> * set delay for polite updates * use delay in relations tab update and date pickr update * remove the usage of aria live region update message in relations tab, since we should handle update message here in another way * use assistive technology instead of screen reader only * change the stream action to live region * change the aria action to live region * remove alert role * change the string in away that if there is no value for start date, finish date or duration, it shouldn't be part of the string * remove aria-live from input text fields * test for updated message in date pickr * undo changes for relations updates * check if message is null then return * add more delay for updating data in date picker * fix test for adding more delay for updating data in date picker --------- Co-authored-by: Henriette Darge <h.darge@openproject.com> Co-authored-by: Alexander Brandon Coles <a.coles@openproject.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )