Skip to content

Commit 475092f

Browse files
authored
Remove dependabot configs for npm-based dependencies (prometheus#16307)
This is just IMO, but getting my inbox flooded every month with hundreds of dependabot PRs is annoying, even if I don't end up handling most of them myself (thanks to others who do!). And then philosophically, I don't know if this is even the right approach. I don't think that whoever merges these PRs actually has the capacity or the knowledge to check that everything is still working as expected. Often subtle things can break after package updates, like a class name from an npm package not fitting to a style definition in our code anymore (as happened once with e.g. codemirror in the past, and nobody noticed when merging, and that bug is still present in Thanos' port of our UI). And you can't look in detail at the UI for every little PR that dependabot sends. Node module dependencies are inherently very noisy because there are so many of them, but I think a better approach would be to update them maybe once or twice a year (or whenever really needed), with all deps updated together, at a time when a maintainer has the time to really look at things carefully, and then do a comprehensive manual check of the UI to see that everything is still behaving as before. Signed-off-by: Julius Volz <julius.volz@gmail.com>
1 parent 5d2b760 commit 475092f

File tree

1 file changed

+0
-20
lines changed

1 file changed

+0
-20
lines changed

.github/dependabot.yml

-20
Original file line numberDiff line numberDiff line change
@@ -25,23 +25,3 @@ updates:
2525
patterns:
2626
- "go.opentelemetry.io/*"
2727
open-pull-requests-limit: 20
28-
# New manteen-ui packages.
29-
- package-ecosystem: "npm"
30-
directory: "/web/ui"
31-
labels:
32-
- dependencies
33-
- javascript
34-
- manteen-ui
35-
schedule:
36-
interval: "monthly"
37-
open-pull-requests-limit: 20
38-
# Old react-app packages.
39-
- package-ecosystem: "npm"
40-
directory: "/web/ui/react-app"
41-
labels:
42-
- dependencies
43-
- javascript
44-
- old-react-ui
45-
schedule:
46-
interval: "monthly"
47-
open-pull-requests-limit: 20

0 commit comments

Comments
 (0)