Merge pull request prometheus#16279 from prometheus/dependabot/npm_and_yarn/web/ui/eslint-9.23.0

chore(deps-dev): bump eslint from 9.18.0 to 9.23.0 in /web/ui

Author: github-actions[bot]

web/ui/mantine-ui/package.json

@@ -59,7 +59,7 @@
     "@typescript-eslint/eslint-plugin": "^8.20.0",
     "@typescript-eslint/parser": "^8.25.0",
     "@vitejs/plugin-react": "^4.3.4",
-    "eslint": "^9.18.0",
+    "eslint": "^9.23.0",
     "eslint-plugin-react-hooks": "^5.1.0",
     "eslint-plugin-react-refresh": "^0.4.19",
     "globals": "^16.0.0",

web/ui/module/codemirror-promql/.eslintrc.json

@@ -0,0 +1,47 @@
+import { fixupConfigRules } from '@eslint/compat';
+import tsParser from '@typescript-eslint/parser';
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
+import js from '@eslint/js';
+import { FlatCompat } from '@eslint/eslintrc';
+
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = path.dirname(__filename);
+const compat = new FlatCompat({
+    baseDirectory: __dirname,
+    recommendedConfig: js.configs.recommended,
+    allConfig: js.configs.all
+});
+
+export default [{
+    ignores: ['**/dist', '**/.eslintrc.cjs', 'node_modules/**'],
+}, ...fixupConfigRules(compat.extends(
+    'eslint:recommended',
+    'plugin:@typescript-eslint/recommended',
+    'plugin:prettier/recommended',
+)), {
+        languageOptions: {
+            parser: tsParser,
+        },
+        rules: {
+            '@typescript-eslint/explicit-function-return-type': ['off'],
+            'eol-last': [
+                'error',
+                'always',
+            ],
+            'object-curly-spacing': [
+                'error',
+                'always',
+            ],
+            'prefer-const': 'warn',
+            'comma-dangle': [
+                'error',
+                {
+                    'arrays': 'always-multiline',
+                    'objects': 'always-multiline',
+                    'imports': 'always-multiline',
+                },
+	    ],
+        },
+    },
+];

web/ui/module/codemirror-promql/eslint.config.mjs

@@ -232,7 +232,8 @@ function isAggregatorWithParam(functionCallBody: SyntaxNode): boolean {
 export function analyzeCompletion(state: EditorState, node: SyntaxNode, pos: number): Context[] {
   const result: Context[] = [];
   switch (node.type.id) {
-    case 0: // 0 is the id of the error node
+    case 0: {
+      // 0 is the id of the error node
       if (node.parent?.type.id === OffsetExpr) {
         // we are likely in the given situation:
         // `metric_name offset 5` that leads to this tree:
@@ -270,7 +271,8 @@ export function analyzeCompletion(state: EditorState, node: SyntaxNode, pos: num
         result.push({ kind: ContextKind.BinOp });
       }
       break;
-    case Identifier:
+    }
+    case Identifier: {
       // sometimes an Identifier has an error has parent. This should be treated in priority
       if (node.parent?.type.id === 0) {
         const errorNodeParent = node.parent.parent;
@@ -380,6 +382,7 @@ export function analyzeCompletion(state: EditorState, node: SyntaxNode, pos: num
         }
       }
       break;
+    }
     case PromQL:
       if (node.firstChild !== null && node.firstChild.type.id === 0) {
         // this situation can happen when there is nothing in the text area and the user is explicitly triggering the autocompletion (with ctrl + space)

web/ui/module/codemirror-promql/src/complete/hybrid.ts

@@ -41,12 +41,13 @@ function createMatcher(labelMatcher: SyntaxNode, state: EditorState): Matcher {
           case QuotedLabelName:
             matcher.name = state.sliceDoc(cursor.from, cursor.to).slice(1, -1);
             break;
-          case MatchOp:
+          case MatchOp: {
             const ope = cursor.node.firstChild;
             if (ope) {
               matcher.type = ope.type.id;
             }
             break;
+          }
           case StringLiteral:
             matcher.value = state.sliceDoc(cursor.from, cursor.to).slice(1, -1);
             break;
@@ -63,12 +64,13 @@ function createMatcher(labelMatcher: SyntaxNode, state: EditorState): Matcher {
           case LabelName:
             matcher.name = state.sliceDoc(cursor.from, cursor.to);
             break;
-          case MatchOp:
+          case MatchOp: {
             const ope = cursor.node.firstChild;
             if (ope) {
               matcher.type = ope.type.id;
             }
             break;
+          }
           case StringLiteral:
             matcher.value = state.sliceDoc(cursor.from, cursor.to).slice(1, -1);
             break;

web/ui/module/codemirror-promql/src/parser/matcher.ts

@@ -959,7 +959,7 @@ describe('promql operations', () => {
       ],
     },
     {
-      expr: `{'foo\`metric':'bar'}`, // eslint-disable-line
+      expr: `{'foo\`metric':'bar'}`,
       expectedValueType: ValueType.vector,
       expectedDiag: [],
     },

web/ui/module/codemirror-promql/src/parser/parser.test.ts

@@ -116,25 +116,27 @@ export class Parser {
       case ParenExpr:
         this.checkAST(node.getChild('Expr'));
         break;
-      case UnaryExpr:
+      case UnaryExpr: {
         const unaryExprType = this.checkAST(node.getChild('Expr'));
         if (unaryExprType !== ValueType.scalar && unaryExprType !== ValueType.vector) {
           this.addDiagnostic(node, `unary expression only allowed on expressions of type scalar or instant vector, got ${unaryExprType}`);
         }
         break;
-      case SubqueryExpr:
+      }
+      case SubqueryExpr: {
         const subQueryExprType = this.checkAST(node.getChild('Expr'));
         if (subQueryExprType !== ValueType.vector) {
           this.addDiagnostic(node, `subquery is only allowed on instant vector, got ${subQueryExprType} in ${node.name} instead`);
         }
         break;
+      }
       case MatrixSelector:
         this.checkAST(node.getChild('Expr'));
         break;
       case VectorSelector:
         this.checkVectorSelector(node);
         break;
-      case StepInvariantExpr:
+      case StepInvariantExpr: {
         const exprValue = this.checkAST(node.getChild('Expr'));
         if (exprValue !== ValueType.vector && exprValue !== ValueType.matrix) {
           this.addDiagnostic(node, `@ modifier must be preceded by an instant selector vector or range vector selector or a subquery`);
@@ -148,6 +150,7 @@ export class Parser {
         //     So far I didn't find the way to fix it. I think it's likely due to the fact we are building an ESM package which is now something stable in nodeJS/javascript but still experimental in typescript.
         // For the above reason, we decided to drop these checks.
         break;
+      }
     }
 
     return getType(node);

web/ui/module/codemirror-promql/src/parser/parser.ts

@@ -52,19 +52,21 @@ export function getType(node: SyntaxNode | null): ValueType {
       return getType(node.getChild('Expr'));
     case UnaryExpr:
       return getType(node.getChild('Expr'));
-    case BinaryExpr:
+    case BinaryExpr: {
       const lt = getType(node.firstChild);
       const rt = getType(node.lastChild);
       if (lt === ValueType.scalar && rt === ValueType.scalar) {
         return ValueType.scalar;
       }
       return ValueType.vector;
-    case FunctionCall:
+    }
+    case FunctionCall: {
       const funcNode = node.firstChild?.firstChild;
       if (!funcNode) {
         return ValueType.none;
       }
       return getFunction(funcNode.type.id).returnType;
+    }
     case StepInvariantExpr:
       return getType(node.getChild('Expr'));
     default: