[pull] main from prometheus:main #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
This is just IMO, but getting my inbox flooded every month with hundreds of dependabot PRs is annoying, even if I don't end up handling most of them myself (thanks to others who do!). And then philosophically, I don't know if this is even the right approach. I don't think that whoever merges these PRs actually has the capacity or the knowledge to check that everything is still working as expected. Often subtle things can break after package updates, like a class name from an npm package not fitting to a style definition in our code anymore (as happened once with e.g. codemirror in the past, and nobody noticed when merging, and that bug is still present in Thanos' port of our UI). And you can't look in detail at the UI for every little PR that dependabot sends. Node module dependencies are inherently very noisy because there are so many of them, but I think a better approach would be to update them maybe once or twice a year (or whenever really needed), with all deps updated together, at a time when a maintainer has the time to really look at things carefully, and then do a comprehensive manual check of the UI to see that everything is still behaving as before. Signed-off-by: Julius Volz <julius.volz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )