Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional Invalidation Option #102

Open
blimmer opened this issue Sep 18, 2018 · 1 comment
Open

Conditional Invalidation Option #102

blimmer opened this issue Sep 18, 2018 · 1 comment

Comments

@blimmer
Copy link

blimmer commented Sep 18, 2018

What if there were an option to only invalidate files if they've changed?

For context, the only time we really have to manually invalidate our cache is when we update our apple-app-site-association file (which is pretty rare). If I understand the code / documentation correctly, it looks like this would trigger an invalidation every time we deploy.

Thoughts?

@kpfefferle
Copy link
Owner

This is an interesting idea and one not considered in the initial implementation since the primary use case invalidates index.html which changes every time a change to a standard Ember application is deployed. I'd certainly be open to a PR that would check for changes, but I'd probably want it to be an opt-in option since I would expect that comparing the currently deployed file on S3 to the newly built version would necessarily add quite a bit of complexity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants